Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #12279

Merged
merged 2 commits into from Mar 16, 2019
Merged

[3.4] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #12279

merged 2 commits into from Mar 16, 2019

Conversation

@tirkarthi
Copy link
Member

@tirkarthi tirkarthi commented Mar 11, 2019 •
edited by bedevere-bot

Don't send cookies of domain A without Domain attribute to domain B when domain A is a suffix match of domain B while using a cookiejar with http.cookiejar.DefaultCookiePolicy policy. Patch by Karthikeyan Singaravelan.
(cherry picked from commit ca7fe50)

Co-authored-by: Xtreak tir.karthi@gmail.com

https://bugs.python.org/issue35121
@tirkarthi
[3.4] bpo-35121: prefix dot in domain for proper subdomain validation (…
Loading status checks…
c90a0e3 
…GH-10258)

Don't send cookies of domain A without Domain attribute to domain B when domain A is a suffix match of domain B while using a cookiejar with `http.cookiejar.DefaultCookiePolicy` policy.  Patch by Karthikeyan Singaravelan.
(cherry picked from commit ca7fe50)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
@bedevere-bot bedevere-bot added the type-security label Mar 11, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 11, 2019
@bedevere-bot bedevere-bot added the awaiting review label Mar 11, 2019
@larryhastings
Merge branch '3.4' into backport-ca7fe50-3.4
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
432137b
@larryhastings larryhastings merged commit 42ad410 into python:3.4 Mar 16, 2019
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
bedevere/issue-number Issue number 35121 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 16, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@bedevere-bot bedevere-bot removed the awaiting review label Mar 16, 2019
@larryhastings
Copy link
Contributor

@larryhastings larryhastings commented Mar 16, 2019

Thanks for the backport! I believe this will be the last substantive revision to get checked into the 3.4 branch.
@tirkarthi tirkarthi deleted the tirkarthi:backport-ca7fe50-3.4 branch Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed type-security
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@tirkarthi @bedevere-bot @larryhastings @the-knights-who-say-ni