bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw #14755

vxgmichel · 2019-07-13T16:04:02Z

Ignore GeneratorExit exceptions when throwing an exception into the aclose coroutine of an asynchronous generator.

https://bugs.python.org/issue35409

Automerge-Triggered-By: @asvetlov


        Ignore GeneratorExit in async_gen_athrow_throw


        Ignore GeneratorExit when throwing into the aclose coroutine of an as…

…ynchronous generator Related issues and pull requests on cpython: - https://bugs.python.org/issue35409 - python/cpython#14755

vxgmichel · 2019-07-17T15:34:55Z

Corresponding PR on pypy: https://bitbucket.org/pypy/pypy/pull-requests/655

1st1

Can you double check if regular generators have the same bahavior before we merge?

vxgmichel · 2019-07-17T16:39:16Z

@1st1

Can you double check if regular generators have the same behavior before we merge?

Well, I don't think this behavior applies to regular generators. The closest thing I could think of is:

>>> def gen():
...     try:
...         yield
...     finally:
...         yield
... 
>>> g = gen()
>>> g.send(None)
>>> g.close()

which produces:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: generator ignored GeneratorExit

Also note that the chunk of code added to async_gen_athrow_throw is directly taken from async_gen_athrow_send. A bit of refactoring might be required, although I don't feel comfortable enough to do it myself. A similar refactoring has been done in pypy: see the handle_error method which is used by both the send and throw methods of the athrow coroutine.

vxgmichel · 2019-10-04T09:15:02Z

Just pinging, as it turns out to be a blocking issue for the aiostream library :)

1st1 · 2019-10-04T14:57:10Z

Andrew, can you take a look at this too?

asvetlov · 2019-10-04T18:01:25Z

Is it urgent?
I'll have time next week only after finishing my business trip.

1st1 · 2019-10-04T19:58:04Z

I guess since we missed the RC1 for this it's no longer urgent. But please look at this as soon as you can. I'd like to hear your opinion.

vxgmichel · 2019-11-19T13:40:04Z

Hi all, I'm just pinging again as I would really like to have this issue fixed :)

asvetlov · 2019-11-19T13:53:37Z

LGTM

miss-islington · 2019-11-19T13:53:53Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2019-11-19T13:53:55Z

Thanks @vxgmichel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2019-11-19T13:53:56Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.


        bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw (pythonGH-1…

…4755) Ignore `GeneratorExit` exceptions when throwing an exception into the `aclose` coroutine of an asynchronous generator. https://bugs.python.org/issue35409 (cherry picked from commit 8e0de2a) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>

bedevere-bot · 2019-11-19T13:54:11Z

GH-17257 is a backport of this pull request to the 3.7 branch.

miss-islington · 2019-11-19T13:54:39Z

Thanks @vxgmichel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!


        bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw (pythonGH-1…

…4755) Ignore `GeneratorExit` exceptions when throwing an exception into the `aclose` coroutine of an asynchronous generator. https://bugs.python.org/issue35409 (cherry picked from commit 8e0de2a) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>

bedevere-bot · 2019-11-19T13:54:48Z

GH-17258 is a backport of this pull request to the 3.8 branch.

asvetlov · 2019-11-19T13:55:29Z

Thanks!


        bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw (GH-14755)

Ignore `GeneratorExit` exceptions when throwing an exception into the `aclose` coroutine of an asynchronous generator. https://bugs.python.org/issue35409 (cherry picked from commit 8e0de2a) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>


        bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw (GH-14755)

Ignore `GeneratorExit` exceptions when throwing an exception into the `aclose` coroutine of an asynchronous generator. https://bugs.python.org/issue35409 (cherry picked from commit 8e0de2a) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>


        bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw (pythonGH-1…

…4755) Ignore `GeneratorExit` exceptions when throwing an exception into the `aclose` coroutine of an asynchronous generator. https://bugs.python.org/issue35409

Ignore GeneratorExit in async_gen_athrow_throw

Loading status checks…

2ee87c8

vxgmichel requested a review from 1st1 as a code owner Jul 13, 2019

the-knights-who-say-ni added the CLA signed label Jul 13, 2019

bedevere-bot added the awaiting review label Jul 13, 2019

1st1 approved these changes Jul 17, 2019

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 17, 2019

1st1 reviewed Jul 17, 2019

View changes

1st1 requested a review from asvetlov Oct 4, 2019

asvetlov added needs backport to 3.7 needs backport to 3.8 labels Nov 19, 2019

asvetlov added 🤖 automerge expert-asyncio labels Nov 19, 2019

bedevere-bot removed the awaiting merge label Nov 19, 2019

bedevere-bot removed the needs backport to 3.7 label Nov 19, 2019

asvetlov added needs backport to 3.8 and removed needs backport to 3.8 labels Nov 19, 2019

bedevere-bot removed the needs backport to 3.8 label Nov 19, 2019

python/cpython

bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw #14755

bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw #14755

vxgmichel commented Jul 13, 2019 •

edited by miss-islington

This comment has been minimized.

vxgmichel commented Jul 17, 2019

1st1 left a comment

This comment has been minimized.

vxgmichel commented Jul 17, 2019

This comment has been minimized.

vxgmichel commented Oct 4, 2019

This comment has been minimized.

1st1 commented Oct 4, 2019

This comment has been minimized.

asvetlov commented Oct 4, 2019 •

edited

This comment has been minimized.

1st1 commented Oct 4, 2019

This comment has been minimized.

vxgmichel commented Nov 19, 2019

This comment has been minimized.

asvetlov commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

bedevere-bot commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

bedevere-bot commented Nov 19, 2019

This comment has been minimized.

asvetlov commented Nov 19, 2019

Sponsor python/cpython

python/cpython

Join GitHub today

bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw #14755

bpo-35409: Ignore GeneratorExit in async_gen_athrow_throw #14755

Conversation

vxgmichel commented Jul 13, 2019 • edited by miss-islington

This comment has been minimized.

vxgmichel commented Jul 17, 2019

1st1 left a comment

This comment has been minimized.

vxgmichel commented Jul 17, 2019

This comment has been minimized.

vxgmichel commented Oct 4, 2019

This comment has been minimized.

1st1 commented Oct 4, 2019

This comment has been minimized.

asvetlov commented Oct 4, 2019 • edited

This comment has been minimized.

1st1 commented Oct 4, 2019

This comment has been minimized.

vxgmichel commented Nov 19, 2019

This comment has been minimized.

asvetlov commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

bedevere-bot commented Nov 19, 2019

This comment has been minimized.

miss-islington commented Nov 19, 2019

This comment has been minimized.

bedevere-bot commented Nov 19, 2019

This comment has been minimized.

asvetlov commented Nov 19, 2019

vxgmichel commented Jul 13, 2019 •

edited by miss-islington

asvetlov commented Oct 4, 2019 •

edited