Skip to content

bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. #16155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2019
Merged

bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. #16155

merged 2 commits into from
Sep 16, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 15, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels Sep 15, 2019
berkerpeksag
berkerpeksag reviewed Sep 15, 2019
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the new code looks much better, thank you very much! I only have two minor comments on the patch.

berkerpeksag
berkerpeksag approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@serhiy-storchaka serhiy-storchaka merged commit 8debfa5 into python:master Sep 16, 2019
@serhiy-storchaka serhiy-storchaka deleted the sqlite-row-compare-leak branch September 16, 2019 17:15
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16193 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16194 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8debfa50407107ff2329d01081cdc12d359f1d12 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
@serhiy-storchaka @miss-islington
bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (p…
38a8a0a 
…ythonGH-16155)

(cherry picked from commit 8debfa5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 17, 2019
@serhiy-storchaka
[2.7] bpo-38175: Fix a memory leak in comparison of sqlite3.Row objec…
bcce759 
…ts. (pythonGH-16155).

(cherry picked from commit 8debfa5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-16215 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Sep 17, 2019
@miss-islington @serhiy-storchaka
bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (G…
f04299d 
…H-16155)

(cherry picked from commit 8debfa5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Sep 17, 2019
@miss-islington @serhiy-storchaka
bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (G…
4ac1be2 
…H-16155)

(cherry picked from commit 8debfa5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Sep 17, 2019
@serhiy-storchaka
[2.7] bpo-38175: Fix a memory leak in comparison of sqlite3.Row objec…
be257bc 
…ts. (GH-16155). (GH-16215)

(cherry picked from commit 8debfa5)
@serhiy-storchaka
Copy link
Member Author

Thank you for your review @berkerpeksag!

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni