Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. #16159

Merged
merged 1 commit into from Sep 15, 2019
Merged

bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. #16159

merged 1 commit into from Sep 15, 2019

Conversation

hniksic
Copy link
Contributor

@hniksic hniksic commented Sep 15, 2019 •
edited by miss-islington

@hniksic hniksic requested review from 1st1 and asvetlov as code owners Sep 15, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 15, 2019
asvetlov
asvetlov approved these changes Sep 15, 2019
View changes
Copy link
Contributor

@asvetlov asvetlov left a comment

The change is correct and reflects the current best practice.

@asvetlov asvetlov added needs backport to 3.7 needs backport to 3.8 skip news 🤖 automerge PR will be merged once it's been approved and all CI passed labels Sep 15, 2019
@miss-islington miss-islington merged commit c717c73 into python:master Sep 15, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Sep 15, 2019

Thanks @hniksic for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 15, 2019

GH-16161 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Sep 15, 2019

GH-16162 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2019
@hniksic @miss-islington
bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (pytho…
d03c931 
…nGH-16159)

https://bugs.python.org/issue38178
(cherry picked from commit c717c73)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
miss-islington added a commit that referenced this pull request Sep 15, 2019
@miss-islington @hniksic
bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159
701c488 
)

https://bugs.python.org/issue38178
(cherry picked from commit c717c73)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
miss-islington added a commit that referenced this pull request Sep 15, 2019
@miss-islington @hniksic
bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159
1cd6e92 
)

https://bugs.python.org/issue38178
(cherry picked from commit c717c73)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@1st1 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hniksic @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni