Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-26730: Fix SpooledTemporaryFile data corruption #17400

Merged
merged 7 commits into from Nov 27, 2019
Merged

bpo-26730: Fix SpooledTemporaryFile data corruption #17400

merged 7 commits into from Nov 27, 2019

Conversation

@methane
Copy link
Member

methane commented Nov 27, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue26730
methane added 3 commits Nov 27, 2019
@methane
bpo-26730: Fix SpooledTemporaryFile data corruption
547b06f 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.
@methane
update doc
ecb8858
@methane
Add NEWS
Loading status checks…
30bb694
@serhiy-storchaka
serhiy-storchaka approved these changes Nov 27, 2019
View changes
Copy link
Member

serhiy-storchaka left a comment

I am not sure about the function to class change. Let to left this to other issue. It needs a separate discussion. It might be discussed earlier.
methane added 4 commits Nov 27, 2019
@methane
revert function -> class
Loading status checks…
adce72b
@methane
Pass errors to TextIOWrapper
Loading status checks…
70aeefa
@methane
write_through is not required
Loading status checks…
4b3d857
@methane
update test
Loading status checks…
c5fac2a
@methane methane merged commit ea9835c into python:master Nov 27, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191127.16 succeeded
Details
bedevere/issue-number Issue number 26730 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@methane methane deleted the methane:text-spooledtempfile branch Nov 27, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 27, 2019

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 27, 2019
@methane @miss-islington
bpo-26730: Fix SpooledTemporaryFile data corruption (pythonGH-17400)
3ff8cc1 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 27, 2019

GH-17405 is a backport of this pull request to the 3.8 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 27, 2019

Sorry, @methane, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ea9835c5d154ab6a54eed627958473b6768b28cc 3.7
methane added a commit that referenced this pull request Nov 27, 2019
@methane
[3.7] bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)
Loading status checks…
ea0fecb 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>.
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 27, 2019

GH-17407 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Nov 28, 2019
@miss-islington @methane
bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d21b8e8 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request Nov 28, 2019
@methane
bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e65b3fa 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>.
(cherry picked from commit ea9835c)
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@methane @serhiy-storchaka @jacobneiltaylor
bpo-26730: Fix SpooledTemporaryFile data corruption (pythonGH-17400)
8c95dd9 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

Assignees

@methane methane

Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
5 participants
@methane @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
You can’t perform that action at this time.