Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38348: Extend options of ast tool #16540

Merged
merged 5 commits into from Dec 16, 2019
Merged

bpo-38348: Extend options of ast tool #16540

merged 5 commits into from Dec 16, 2019
+17 −2

Conversation

@isidentical
Copy link
Contributor

isidentical commented Oct 2, 2019 •
edited by bedevere-bot

--type-comments and --indent

https://bugs.python.org/issue38348
@isidentical
bpo-38348: Extend options of ast tool
Loading status checks…
fc68a96
@brandtbucher
brandtbucher approved these changes Oct 2, 2019
View changes
Copy link
Member

brandtbucher left a comment

This looks good!
@ilevkivskyi
ilevkivskyi reviewed Oct 4, 2019
View changes
Lib/ast.py Outdated Show resolved Hide resolved
@isidentical
type-comments to no-type-comments
Loading status checks…
1871ac9
@isidentical isidentical force-pushed the isidentical:bpo-38348 branch from c337d21 to 1871ac9 Oct 4, 2019
@vstinner
vstinner requested changes Dec 14, 2019
View changes
Doc/library/ast.rst Show resolved Hide resolved
Doc/library/ast.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 14, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@isidentical

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

isidentical commented Dec 15, 2019

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 15, 2019

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from vstinner Dec 15, 2019
@vstinner
vstinner reviewed Dec 15, 2019
View changes
Lib/ast.py Outdated Show resolved Hide resolved
Doc/library/ast.rst Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-10-02-18-15-28.bpo-38348._-5eq2.rst Outdated Show resolved Hide resolved
@isidentical
rearrange news entry, docs
Loading status checks…
ece2cd2
@isidentical isidentical force-pushed the isidentical:bpo-38348 branch from 4b6041d to ece2cd2 Dec 16, 2019
@vstinner
vstinner reviewed Dec 16, 2019
View changes
Copy link
Member

vstinner left a comment

Two more minor requests
Lib/ast.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-10-02-18-15-28.bpo-38348._-5eq2.rst Outdated Show resolved Hide resolved
isidentical and others added 2 commits Dec 16, 2019
@isidentical @vstinner
dont => don't
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
189f9e5 
Co-Authored-By: Victor Stinner <vstinner@python.org>
@isidentical @vstinner
indent => indentation level
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb9ce64 
Co-Authored-By: Victor Stinner <vstinner@python.org>
@vstinner
vstinner approved these changes Dec 16, 2019
View changes
Copy link
Member

vstinner left a comment

LGTM.
@vstinner vstinner merged commit 814d687 into python:master Dec 16, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191216.15 succeeded
Details
bedevere/issue-number Issue number 38348 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi

@brandtbucher brandtbucher

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed type-enhancement
Projects
None yet
Milestone
No milestone
6 participants
@isidentical @bedevere-bot @vstinner @ilevkivskyi @brandtbucher @the-knights-who-say-ni
You can’t perform that action at this time.