Undefined name: 'commandline' --> 'cmd' #13038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ___undefined variable___ __commandline__ is used but is never defined. __cmd__ is defined on line 1529 and is used on 1534. @ned-deily Your review please. [flake8](http://flake8.pycqa.org) testing of https://github.com/python/cpython on Python 3.7.1 $ __flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics__ ``` ./Mac/BuildScript/build-installer.py:1272:17: F821 undefined name 'build_time_vars' for k, v in build_time_vars.items(): ^ ./Mac/BuildScript/build-installer.py:1543:50: F821 undefined name 'commandline' raise RuntimeError("command failed: %s"%(commandline,)) ^ ``` __E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety. * F821: undefined name `name` * F822: undefined name `name` in `__all__` * F823: local variable name referenced before assignment * E901: SyntaxError or IndentationError * E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
auvipy
approved these changes
May 2, 2019
|
Thanks @cclauss for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2019
) (cherry picked from commit d337169) Co-authored-by: cclauss <cclauss@me.com>
|
GH-13766 is a backport of this pull request to the 3.7 branch. |
|
GH-13767 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2019
) (cherry picked from commit d337169) Co-authored-by: cclauss <cclauss@me.com>
miss-islington
added a commit
that referenced
this pull request
Jun 3, 2019
(cherry picked from commit d337169) Co-authored-by: cclauss <cclauss@me.com>
miss-islington
added a commit
that referenced
this pull request
Jun 3, 2019
(cherry picked from commit d337169) Co-authored-by: cclauss <cclauss@me.com>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The undefined variable commandline is used but is never defined. cmd is defined on line 1529 and is used on 1534. @ned-deily Your review please.
flake8 testing of https://github.com/python/cpython on Python 3.7.1
$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics
E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
namenamein__all__