bpo-37362: test_gdb now ignores stderr #14287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
added
needs backport to 2.7
needs backport to 3.7
needs backport to 3.8
and removed
awaiting core review
tests
davidmalcolm
reviewed
Jun 21, 2019
Misc/NEWS.d/next/Tests/2019-06-21-15-47-33.bpo-37362.D3xppx.rst
Outdated
Show resolved
Hide resolved
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb.
vstinner
force-pushed
the
WIP_test_gdb_ignore_stderr
branch
from
cefff8e
to
3417178
Compare
|
Oh, I didn't expect that I would have the honor of getting a review of the author of the original code author :-) Dave Malcolm! He wrote "(...) your approach looks good to me": https://bugs.python.org/issue37362#msg346221 |
|
Thanks @vstinner for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2019
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb. (cherry picked from commit e56a123) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
GH-14295 is a backport of this pull request to the 3.8 branch. |
|
GH-14296 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2019
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb. (cherry picked from commit e56a123) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-14297 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 21, 2019
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb. (cherry picked from commit e56a123) Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington
added a commit
that referenced
this pull request
Jun 21, 2019
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb. (cherry picked from commit e56a123) Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner
added a commit
that referenced
this pull request
Jun 21, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
test_gdb no longer fails if it gets an "unexpected" message on stderr: it now ignores stderr. The purpose of test_gdb is to test that python-gdb.py commands work as expected, not to test gdb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
test_gdb no longer fails if it gets an "unexpected" message on
stderr: it now ignores stderr. The purpose of test_gdb is to test
that python-gdb.py commands work as expected, not to test gdb.
https://bugs.python.org/issue37362