[3.6] bpo-35601: Alleviate race condition when waiting for SIGALRM in test_asyncio (GH-11337) #11348
Conversation
…asyncio (pythonGH-11337) There is a race condition regarding signal delivery in test_signal_handling_args for test_asyncio.test_events.KqueueEventLoopTests. The signal can be received at any moment outside the time window provided in the test. The fix is to wait for the signal to be received instead with a bigger timeout. (cherry picked from commit 5471420) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
@pablogsal: Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
|
@ned-deily What are we supposed to do with PRs eliminating races in the testing suite in the 3.6 branch? Should we close this PR as only security fixes are allowed in 3.6 now? |
|
The dev guide discusses fixes for hard-failing tests in security-fix-only branches. Since we are still at the beginning of that phase for 3.6, I’m inclined to accept this PR After it’s had some exposure elsewhere. So just leave it open for now, thanks. |
|
Thanks for the rapid response! There are a couple of PRs appart from this one eliminating races that happened recently. If we are going to retire soon the 3.6 buildbots I am on with not merging them :) |
There is a race condition regarding signal delivery in test_signal_handling_args for
test_asyncio.test_events.KqueueEventLoopTests. The signal can be received at any moment outside the time window provided in the test. The fix is to wait for the signal to be received instead with a bigger timeout.
(cherry picked from commit 5471420)
Co-authored-by: Pablo Galindo Pablogsal@gmail.com
https://bugs.python.org/issue35601