Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36225: Finalise subinterpreters in Py_FinalizeEx() #17575

Open
wants to merge 5 commits into
base: master
from
Open

bpo-36225: Finalise subinterpreters in Py_FinalizeEx() #17575

wants to merge 5 commits into from
+66 −0

Conversation

@LewisGaul
Copy link

LewisGaul commented Dec 11, 2019 •
edited by bedevere-bot

  • Added testcase in Programs/_testembed.c - previously failing, now passing
  • Loop over interpreters in Py_FinalizeEx() and call Py_EndInterpreter() (apart from on main interpreter)
  • New flag _PyRuntime.interpreters.finalizing to prevent new subinterpreters from being created during finalisation

https://bugs.python.org/issue36225
Lewis Gaul added 2 commits Nov 21, 2019
Lewis Gaul
Add test suggested by ncoghlan
23af5f5
Lewis Gaul
Finalise sub-interpreters in Py_FinalizeEx()
Loading status checks…
433663c
@LewisGaul

This comment has been minimized.

Sign in to view
Copy link
Author

LewisGaul commented Dec 11, 2019

I need to look into test_audit_subinterpreter() testcase, will do so at some point soon.
Lewis Gaul added 2 commits Dec 13, 2019
Lewis Gaul
Improve test name
48e1cfc
Lewis Gaul
Switch back to main threadstate in test_audit_subinterpreter before c…
Loading status checks…
0400634 
…alling Py_Finalize()
@LewisGaul

This comment has been minimized.

Sign in to view
Copy link
Author

LewisGaul commented Dec 13, 2019

As noted here, it seems test_audit_subinterpreter() was failing because it was trying to call Py_Finalize() from a subinterpreter. Hopefully now fixed by switching back to the main threadstate in that testcase.
@ericsnowcurrently ericsnowcurrently self-requested a review Dec 14, 2019
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b79649c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@LewisGaul @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.