Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the OverflowError test for test_truediv on test_complex #16591

Merged
merged 1 commit into from Oct 10, 2019
Merged

Re-enable the OverflowError test for test_truediv on test_complex #16591

merged 1 commit into from Oct 10, 2019

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 5, 2019 •
edited

This code was added 17 years ago. It works well today.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 5, 2019
@corona10 corona10 requested a review from serhiy-storchaka Oct 5, 2019
@corona10
Copy link
Member Author

corona10 commented Oct 5, 2019

@serhiy-storchaka Please take a look

@serhiy-storchaka serhiy-storchaka requested review from mdickinson and removed request for serhiy-storchaka Oct 5, 2019
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 5, 2019

I think @mdickinson is more accomplished in this.

mdickinson
mdickinson approved these changes Oct 8, 2019
View changes
Copy link
Member

@mdickinson mdickinson left a comment

LGTM

@corona10
Copy link
Member Author

corona10 commented Oct 10, 2019

@serhiy-storchaka
Merge this PR please :)

@serhiy-storchaka serhiy-storchaka merged commit 1dbe537 into python:master Oct 10, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 10, 2019

Thanks @corona10 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2019
@corona10 @miss-islington
Re-enable the OverflowError test for test_truediv on test_complex (py…
bd6a82e 
…thonGH-16591)

(cherry picked from commit 1dbe537)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 10, 2019

GH-16703 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 10, 2019
@miss-islington @corona10
Re-enable the OverflowError test for test_truediv on test_complex (GH…
398d847 
…-16591)

(cherry picked from commit 1dbe537)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@corona10 corona10 deleted the remove_fixme_on_test_complex branch Oct 11, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@corona10
Re-enable the OverflowError test for test_truediv on test_complex (py…
ad43bcc 
…thonGH-16591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@corona10 @serhiy-storchaka @miss-islington @bedevere-bot @mdickinson @the-knights-who-say-ni