Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-38376: Fix _PyUnicode_CheckConsistency() definition #16623

Merged
merged 1 commit into from Oct 7, 2019
Merged

[3.8] bpo-38376: Fix _PyUnicode_CheckConsistency() definition #16623

merged 1 commit into from Oct 7, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 7, 2019 •
edited by bedevere-bot

Always define _PyUnicode_CheckConsistency() in the CPython C API.

https://bugs.python.org/issue38376

@vstinner vstinner requested a review from Yhg1s October 7, 2019 16:24
This was referenced Oct 7, 2019
Closed
Merged
@vstinner
bpo-38376: Fix _PyUnicode_CheckConsistency() definition
0acc80b 
Always define _PyUnicode_CheckConsistency() in the CPython C API.
@vstinner
Copy link
Member Author

vstinner commented Oct 7, 2019

I tested manually that Python build correctly with the following commands:

./configure --prefix=$HOME/.local --with-assertions
make

@vstinner vstinner merged commit 435b2ee into python:3.8 Oct 7, 2019
@vstinner vstinner deleted the check_consistency38 branch October 7, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yhg1s Yhg1s

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot