Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38453: Resolve test directories before chdir to them #16723

Merged
merged 1 commit into from Oct 14, 2019
Merged

bpo-38453: Resolve test directories before chdir to them #16723

merged 1 commit into from Oct 14, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Oct 11, 2019 •
edited by bedevere-bot

@zooba zooba added tests Tests in the Lib/test dir needs backport to 3.8 labels Oct 11, 2019
@zooba zooba merged commit d83fc27 into python:master Oct 14, 2019
@zooba zooba deleted the bpo-38453 branch Oct 14, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 14, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 14, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 14, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2019
@zooba @miss-islington
bpo-38453: Resolve test directories before chdir to them (pythonGH-16723
3abd857 
)

(cherry picked from commit d83fc27)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Oct 14, 2019

GH-16783 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 14, 2019
@miss-islington @zooba
bpo-38453: Resolve test directories before chdir to them (GH-16723)
aa909b6 
(cherry picked from commit d83fc27)

Co-authored-by: Steve Dower <steve.dower@python.org>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@zooba
bpo-38453: Resolve test directories before chdir to them (pythonGH-16723
fc03a08 
)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@zooba @shihai1991
bpo-38453: Resolve test directories before chdir to them (pythonGH-16723
0823c17 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni