bpo-37759: More updates to Whatsnew 3.8 #16854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other minor fixes as well. Also, dedup the __reduce__ entry.
aeros
reviewed
Oct 20, 2019
aeros
reviewed
Oct 20, 2019
aeros
reviewed
Oct 20, 2019
aeros
reviewed
Oct 20, 2019
|
Thanks @rhettinger for the PR |
|
GH-16867 is a backport of this pull request to the 3.8 branch. |
rhettinger
added a commit
that referenced
this pull request
Oct 20, 2019
* math.perm() and math.comb() * math.isqrt() * Add singledispatchmethod() * itertools.accumulate() * Optional headers for xmlrpc.client.ServerProxy * IDLE non-BMP characters * import collections.abc directly * @coroutine is deprecated * pprint.pp() * New options for object.__reduce__() * DictReader no longer returns OrderedDicts * "force" option for logging.basicConfig() * Fix spelling * cProfile context manager * Various markup/grammar fixes from Kyle Stanley. Other minor fixes as well. Also, dedup the __reduce__ entry. * Fix markup * Fix grammar nits found by MS Word (cherry picked from commit c93883c) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
serhiy-storchaka
reviewed
Oct 20, 2019
| element is a callable with a ``(obj, state)`` signature. This allows the | ||
| direct control over the state-updating behavior of a specific object. If | ||
| not *None*, this callable will have priority over the object's | ||
| :meth:`~__setstate__` method. |
There was a problem hiding this comment.
~ is not needed here. It could be :meth:`~object.__setstate__`, but maybe :meth:`__setstate__` is enough.
There was a problem hiding this comment.
:meth:`__setstate__`
IIRC, the above does not correctly generate an inline link. This applies to the other dunder methods and attributes inherited from object as well, it has to be:
:meth:`object.__setstate__`
Usually, I've used:
:meth:`~object.__setstate__`
since only the __setstate__ part is relevant for the context of the readers.
| ------- | ||
|
|
||
| Added a *force* keyword argument to :func:`logging.basicConfig()` | ||
| When set to *True*, any existing handlers attached |
There was a problem hiding this comment.
It is usually written as ``True``.
| @@ -973,8 +1109,8 @@ The :func:`socket.if_nameindex()`, :func:`socket.if_nametoindex()`, and | |||
| ssl | |||
| --- | |||
|
|
|||
| Added :attr:`ssl.SSLContext.post_handshake_auth` to enable and | |||
| :meth:`ssl.SSLSocket.verify_client_post_handshake` to initiate TLS 1.3 | |||
| Added :attr:`~ssl.SSLContext.post_handshake_auth` to enable and | |||
There was a problem hiding this comment.
The module is known from the context, but it is not clear what classes the attribute and the method belong to. Maybe you meant :attr:`SSLContext.post_handshake_auth <ssl.SSLContext.post_handshake_auth>`?
There are similar issues with some other uses of the tilde. It lefts only the last component.
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
* math.perm() and math.comb() * math.isqrt() * Add singledispatchmethod() * itertools.accumulate() * Optional headers for xmlrpc.client.ServerProxy * IDLE non-BMP characters * import collections.abc directly * @coroutine is deprecated * pprint.pp() * New options for object.__reduce__() * DictReader no longer returns OrderedDicts * "force" option for logging.basicConfig() * Fix spelling * cProfile context manager * Various markup/grammar fixes from Kyle Stanley. Other minor fixes as well. Also, dedup the __reduce__ entry. * Fix markup * Fix grammar nits found by MS Word
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
* math.perm() and math.comb() * math.isqrt() * Add singledispatchmethod() * itertools.accumulate() * Optional headers for xmlrpc.client.ServerProxy * IDLE non-BMP characters * import collections.abc directly * @coroutine is deprecated * pprint.pp() * New options for object.__reduce__() * DictReader no longer returns OrderedDicts * "force" option for logging.basicConfig() * Fix spelling * cProfile context manager * Various markup/grammar fixes from Kyle Stanley. Other minor fixes as well. Also, dedup the __reduce__ entry. * Fix markup * Fix grammar nits found by MS Word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue37759