Skip to content

Slightly improve plistlib test coverage #17025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2019
Merged

Slightly improve plistlib test coverage #17025

merged 5 commits into from
Nov 1, 2019

Conversation

bigfootjon
Copy link
Contributor

I don't think this warrants a b.p.o issue, but I'm happy to create one if necessary

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 1, 2019
@brandtbucher
Copy link
Member

Thanks for the PR!

CC @serhiy-storchaka, #4455 was yours.

brandtbucher
brandtbucher requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments:

serhiy-storchaka
serhiy-storchaka reviewed Nov 1, 2019
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@serhiy-storchaka serhiy-storchaka merged commit d0d9f7c into python:master Nov 1, 2019
@bigfootjon bigfootjon deleted the plistlib-improve-tests branch November 1, 2019 16:45
@miss-islington
Copy link
Contributor

Thanks @bigfootjon for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @bigfootjon for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @bigfootjon and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d0d9f7cfa36bafa4e1d9e73eb08835180d376df1 3.7

@miss-islington
Copy link
Contributor

Sorry @bigfootjon and @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d0d9f7cfa36bafa4e1d9e73eb08835180d376df1 3.8

@bigfootjon
Copy link
Contributor Author

bigfootjon commented Nov 1, 2019 •
edited
Loading

This can't be backported to 3.7, UID didn't exist until 3.8 @serhiy-storchaka

Edit: Well unittest.main() can be if you just want that line?

@bedevere-bot
Copy link

GH-17028 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka pushed a commit that referenced this pull request Nov 2, 2019
@bigfootjon @serhiy-storchaka
[3.8] Slightly improve plistlib test coverage. (GH-17025) (GH-17028)
fe934e1 
* Add missing test class (mistake in GH-4455)

* Increase coverage with 4 more test cases

* Rename neg_uid to huge_uid in test_modified_uid_huge

* Replace test_main() with unittest.main()

* Update plistlib docs.
(cherry picked from commit d0d9f7c)

Co-authored-by: Jon Janzen <jjjonjanzen@gmail.com>
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @bigfootjon!

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@bigfootjon
Slightly improve plistlib test coverage. (pythonGH-17025)
23ce400 
* Add missing test class (mistake in pythonGH-4455)

* Increase coverage with 4 more test cases

* Rename neg_uid to huge_uid in test_modified_uid_huge

* Replace test_main() with unittest.main()

* Update plistlib docs
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@bigfootjon @shihai1991
Slightly improve plistlib test coverage. (pythonGH-17025)
f2527f0 
* Add missing test class (mistake in pythonGH-4455)

* Increase coverage with 4 more test cases

* Rename neg_uid to huge_uid in test_modified_uid_huge

* Replace test_main() with unittest.main()

* Update plistlib docs
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bigfootjon @brandtbucher @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni