bpo-37236: pragma optimize off for _Py_c_quot on Windows arm64 #13983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
reviewed
Jun 12, 2019
Co-Authored-By: Steve Dower <steve.dower@microsoft.com>
|
I merged the suggested comment |
|
GH-14024 is a backport of this pull request to the 3.8 branch. |
|
Thanks! |
miss-islington
added a commit
that referenced
this pull request
Jun 12, 2019
) (cherry picked from commit ff6bb0a) Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a compiler optimization error on Windows ARM64 that causes test_truediv (test.test_complex.ComplexTest) to fail with ZeroDivisionError: complex division by zero.
Adding a pragma optimize around the affected function fixes the issue. I am also submitting a report to the compiler team
@zooba
https://bugs.python.org/issue37236