Skip to content

bpo-39050: The Help button in IDLE's config menu does not work #17611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 23, 2020
Merged

bpo-39050: The Help button in IDLE's config menu does not work #17611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e5c5b7
bpo-39050: The Help button in IDLE's config menu does not work
ZackerySpytz Dec 14, 2019
9d39349
Merge remote-tracking branch 'upstream/master' into bpo-39050-idle-he…
ZackerySpytz Jan 21, 2020
c2378d1
Remove spaces.
ZackerySpytz Jan 21, 2020
78f3ece
Add help button test.
terryjreedy Jan 23, 2020
9c28dde
blurb
terryjreedy Jan 23, 2020
472d060
Merge remote-tracking branch 'origin/master' into pr_17611
terryjreedy Jan 23, 2020
4f29d01
NEWS.txt item.
terryjreedy Jan 23, 2020
b5f5ff4
Update 2020-01-22-22-28-06.bpo-39050.zkn0FO.rst
terryjreedy Jan 23, 2020
66562bd
Update NEWS.txt
terryjreedy Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/NEWS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ Released on 2020-10-05?
======================================


bpo-39050: Make Settings dialog Help button work again.

bpo-32989: Add tests for editor newline_and_indent_event method.
Remove dead code from pyparse find_good_parse_start method.

Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def help(self):
"""
page = self.note.tab(self.note.select(), option='text').strip()
view_text(self, title='Help for IDLE preferences',
text=help_common+help_pages.get(page, ''))
contents=help_common+help_pages.get(page, ''))

def deactivate_current_config(self):
"""Remove current key bindings.
Expand Down
11 changes: 11 additions & 0 deletions Lib/idlelib/idle_test/test_configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,17 @@ def tearDownModule():
root.destroy()
root = dialog = None

class ConfigDialogTest(unittest.TestCase):

def test_help(self):
dialog.note.select(dialog.keyspage)
saved = configdialog.view_text
view = configdialog.view_text = Func()
dialog.help()
s = view.kwds['contents']
self.assertTrue(s.startswith('When you click'))
self.assertTrue(s.endswith('a different name.\n'))
configdialog.view_text = saved

class FontPageTest(unittest.TestCase):
"""Test that font widgets enable users to make font changes.
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2020-01-22-22-28-06.bpo-39050.zkn0FO.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make IDLE Settings dialog Help button work again.