Skip to content

[2.7] bpo-16039: CVE-2013-1752: Limit imaplib.IMAP4_SSL.readline() #11120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2018
Merged

[2.7] bpo-16039: CVE-2013-1752: Limit imaplib.IMAP4_SSL.readline() #11120

merged 1 commit into from
Dec 12, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 11, 2018 •
edited
Loading

  • bpo-16039: CVE-2013-1752: Change use of readline() in
    imaplib.IMAP4_SSL to limit line length. Remove IMAP4_SSL.readline()
    and IMAP4_SSL.read() to inherit IMAP4 implementation.
  • bpo-20118: reenable ThreadedNetworkedTests.test_linetoolong()
    of test_imaplib. The test now sets the _MAXLINE limit to 10
    characters.

https://bugs.python.org/issue16039
https://bugs.python.org/issue20118

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Dec 11, 2018
@vstinner
bpo-16039: CVE-2013-1752: Limit imaplib.IMAP4_SSL.readline()
da77a30 
* bpo-16039: CVE-2013-1752: Change use of readline() in
  imaplib.IMAP4_SSL to limit line length. Remove IMAP4_SSL.readline()
  and IMAP4_SSL.read() to inherit IMAP4 implementation.
* bpo-20118: reenable ThreadedNetworkedTests.test_linetoolong()
  of test_imaplib. The test now sets the _MAXLINE limit to 10
  characters.
@vstinner vstinner changed the title [2.7] bpo-20118, test_imaplib: reenable test_linetoolong() [2.7] bpo-16039: CVE-2013-1752: Limit imaplib.IMAP4_SSL.readline() Dec 11, 2018
@vstinner vstinner added the type-security A security issue label Dec 11, 2018
@vstinner vstinner requested review from tiran, a team and bitdancer December 11, 2018 15:09
@vstinner vstinner merged commit 16d6320 into python:2.7 Dec 12, 2018
@vstinner vstinner deleted the test_imaplib27 branch December 12, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran Awaiting requested review from tiran

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot