Skip to content

[2.7] bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

[2.7] bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. #9626

merged 1 commit into from
Jun 9, 2019

Conversation

xnox
Copy link

@xnox xnox commented Sep 28, 2018 •
edited by bedevere-bot
Loading

@xnox xnox requested a review from a team September 28, 2018 16:34
@xnox xnox requested a review from a team as a code owner September 28, 2018 16:34
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@xnox xnox changed the base branch from master to 2.7 September 28, 2018 16:34
@skrah skrah removed their request for review September 28, 2018 16:39
@brettcannon brettcannon removed the request for review from a team September 29, 2018 00:08
@tiran
Copy link
Member

tiran commented Dec 26, 2018

The patch looks good to me. Please include a news entry.

@xnox
Copy link
Author

xnox commented Jan 11, 2019

@tiran added a NEWS entry, hopefully correctly.

@xnox
Copy link
Author

xnox commented May 29, 2019

What can I do to get this reviewed / merged? I do not understand the current state of this PR.

@encukou encukou changed the title bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. [2.7] bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. May 29, 2019
@encukou
Copy link
Member

encukou commented May 29, 2019

I changed the title to make the bot happy.
But an SSL expert (like @tiran) should merge this. I'm not brave enough to do it.

ncoghlan
ncoghlan approved these changes Jun 9, 2019
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiran already reviewed the test change above, it was just pending the NEWS entry.

@ncoghlan ncoghlan merged commit 99b5c94 into python:2.7 Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

@gpshead gpshead Awaiting requested review from gpshead

@rhettinger rhettinger Awaiting requested review from rhettinger

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@tiran tiran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xnox @the-knights-who-say-ni @tiran @encukou @ncoghlan @bedevere-bot