bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines #17366

terryjreedy · 2019-11-24T03:17:29Z

Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py.

https://bugs.python.org/issue38862


        bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines

A non-blank non-shell window should end with exactly one newline following something other than space, tab, or newline. It should then be ready to commit to the cpython repository.


        Add text parameter to mock Editor so a tk Text can be passed in.


        Add new code and test for fixing endlines.


        idlelib NEWS.txt entry


        Update IDLE doc and help.html.

terryjreedy · 2019-11-24T03:19:30Z

I think that this is ready to merge, but will wait half a day before doing so and moving on to invoking rstrip on save.

terryjreedy · 2019-11-24T03:28:25Z

Spec was revised after patchcheck experiment. See bpo-36682.

taleinat

Looks good Terry, just a few small comments for your consideration.

Lib/idlelib/idle_test/mock_idle.py

Lib/idlelib/idle_test/test_format.py

Misc/NEWS.d/next/IDLE/2019-11-23-21-50-57.bpo-38862.KQ9A0m.rst


        Merge remote-tracking branch 'upstream/master' into endlines


        Be explicit on slice bounds.


        Remove newline addition.


        Change doc and news.

taleinat

LGTM

miss-islington · 2019-11-24T21:29:32Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖


        bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (pythonG…

…H-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2019-11-24T21:29:53Z

GH-17370 is a backport of this pull request to the 3.8 branch.

bedevere-bot · 2019-11-24T21:30:00Z

GH-17371 is a backport of this pull request to the 3.7 branch.


        bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (pythonG…

…H-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington · 2019-11-25T20:11:37Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington · 2019-11-25T20:11:37Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2019-11-25T20:27:12Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

miss-islington · 2019-11-25T20:27:15Z

Sorry, @terryjreedy, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6bf644ec82f14cceae68278dc35bafb00875efae 2.7

miss-islington · 2019-11-25T20:29:44Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2019-11-25T20:29:46Z

Sorry @terryjreedy, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6bf644ec82f14cceae68278dc35bafb00875efae 3.7


        [3.7] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (p…

…ythonGH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2019-11-25T20:37:58Z

GH-17379 is a backport of this pull request to the 3.7 branch.


        [3.8] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (p…

…ythonGH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>


        [3.7] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (G…

…H-17366) (#17379) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>


        [3.8] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (G…

…H-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py. (cherry picked from commit 6bf644e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>


         bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (python…

…GH-17366) Extra newlines are removed at the end of non-shell files. If the file only has newlines after stripping other trailing whitespace, all are removed, as is done by patchcheck.py.

terryjreedy added 5 commits Nov 24, 2019

bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines

45b6e3a

A non-blank non-shell window should end with exactly one newline following something other than space, tab, or newline. It should then be ready to commit to the cpython repository.

Add text parameter to mock Editor so a tk Text can be passed in.

db5d873

Add new code and test for fixing endlines.

f4dcabc

idlelib NEWS.txt entry

9a4d241

Update IDLE doc and help.html.

Loading status checks…

fff243b

terryjreedy added type-enhancement needs backport to 3.7 needs backport to 3.8 labels Nov 24, 2019

terryjreedy requested a review from taleinat Nov 24, 2019

terryjreedy self-assigned this Nov 24, 2019

the-knights-who-say-ni added the CLA signed label Nov 24, 2019

bedevere-bot added the awaiting core review label Nov 24, 2019

taleinat reviewed Nov 24, 2019

View changes

terryjreedy added 4 commits Nov 24, 2019

Merge remote-tracking branch 'upstream/master' into endlines

b2b32f4

Be explicit on slice bounds.

3fc2659

Remove newline addition.

d13fc65

Change doc and news.

Loading status checks…

636c15f

taleinat approved these changes Nov 24, 2019

View changes

bedevere-bot added awaiting merge and removed awaiting core review labels Nov 24, 2019

terryjreedy deleted the terryjreedy:endlines branch Nov 24, 2019

bedevere-bot removed the awaiting merge label Nov 24, 2019

bedevere-bot removed the needs backport to 3.8 label Nov 24, 2019

bedevere-bot removed the needs backport to 3.7 label Nov 24, 2019

python deleted a comment Nov 24, 2019

python deleted a comment Nov 25, 2019

terryjreedy added needs backport to 3.7 needs backport to 3.8 labels Nov 25, 2019

terryjreedy added the needs backport to 2.7 label Nov 25, 2019

terryjreedy added needs backport to 3.7 and removed needs backport to 2.7 needs backport to 3.8 needs backport to 3.7 labels Nov 25, 2019

terryjreedy mentioned this pull request Nov 25, 2019

[3.7] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (GH-17366) #17379

Merged

bedevere-bot removed the needs backport to 3.7 label Nov 25, 2019

python/cpython

bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines #17366

bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines #17366

terryjreedy commented Nov 24, 2019 •

edited

This comment has been minimized.

terryjreedy commented Nov 24, 2019

This comment has been minimized.

terryjreedy commented Nov 24, 2019 •

edited by bedevere-bot

taleinat left a comment

taleinat left a comment

This comment has been minimized.

miss-islington commented Nov 24, 2019

This comment has been minimized.

bedevere-bot commented Nov 24, 2019

This comment has been minimized.

bedevere-bot commented Nov 24, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

bedevere-bot commented Nov 25, 2019

Sponsor python/cpython

python/cpython

Join GitHub today

bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines #17366

bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines #17366

Conversation

terryjreedy commented Nov 24, 2019 • edited

This comment has been minimized.

terryjreedy commented Nov 24, 2019

This comment has been minimized.

terryjreedy commented Nov 24, 2019 • edited by bedevere-bot

taleinat left a comment

taleinat left a comment

This comment has been minimized.

miss-islington commented Nov 24, 2019

This comment has been minimized.

bedevere-bot commented Nov 24, 2019

This comment has been minimized.

bedevere-bot commented Nov 24, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

miss-islington commented Nov 25, 2019

This comment has been minimized.

bedevere-bot commented Nov 25, 2019

terryjreedy commented Nov 24, 2019 •

edited

terryjreedy commented Nov 24, 2019 •

edited by bedevere-bot