bpo-36010: Add venv to the nuget distribution #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
changed the title
|
Note: See the comment on bpo, but as it stands this PR does not achieve the desired effect of adding venv to the nuget package. |
zooba
reviewed
Mar 21, 2019
PC/layout/support/options.py
Outdated
| "stable", | ||
| "distutils", | ||
| "venv", | ||
| "launchers", |
There was a problem hiding this comment.
I suspect we don't actually want this one. The original option was "launcher" (no "s"), which means it isn't including this.
IIRC, "launchers" is specific to the APPX package.
There was a problem hiding this comment.
Yeah, the include_launchers option is only referenced in one place and looks like this:
if ns.include_launchers and ns.include_appxmanifest:
if ns.include_pip:
yield from in_build("python_uwp.exe", new_name="pip")
if ns.include_idle:
yield from in_build("pythonw_uwp.exe", new_name="idle")So no need for it here
|
Thanks, Paul! |
|
GH-12634 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 30, 2019
(cherry picked from commit e724152) Co-authored-by: Paul Moore <p.f.moore@gmail.com>
zooba
pushed a commit
that referenced
this pull request
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds the venv standard library module to the nuget distribution.
https://bugs.python.org/issue36010