Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38944: Escape key now closes IDLE completion windows. #17419

Merged
merged 5 commits into from Dec 9, 2019
Merged

bpo-38944: Escape key now closes IDLE completion windows. #17419

merged 5 commits into from Dec 9, 2019
+5 −1

Conversation

@JohnnyNajera
Copy link
Contributor

JohnnyNajera commented Nov 30, 2019 •
edited

Autocomplete window is not closed on Escape key on some Ubuntu systems. This is because the key press never make it to the event.

https://bugs.python.org/issue38944
@JohnnyNajera
Fixing Escape key not bound to KeyPress event
Loading status checks…
dd3350a
@JohnnyNajera JohnnyNajera requested a review from terryjreedy as a code owner Nov 30, 2019
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Nov 30, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JohnnyNajera

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2bf7626
@JohnnyNajera JohnnyNajera changed the title bop-38944: Fixing Escape key not bound to KeyPress event bpo-38944: Fixing Escape key not bound to KeyPress event Nov 30, 2019
@JohnnyNajera
Grammar
Loading status checks…
fa35acf
@JohnnyNajera JohnnyNajera force-pushed the JohnnyNajera:fix-autocomplete-close-on-escape branch from 4ac2225 to fa35acf Nov 30, 2019
@JohnnyNajera JohnnyNajera changed the title bpo-38944: Fixing Escape key not bound to KeyPress event bpo-38944: Fix Escape key not bound to KeyPress event Dec 3, 2019
@JohnnyNajera

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

JohnnyNajera commented Dec 4, 2019

I have made the requested changes; please review again.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 4, 2019

Thanks for making the requested changes!

: please review the changes made to this pull request.
@JohnnyNajera JohnnyNajera mentioned this pull request Dec 5, 2019
Merged
terryjreedy added 2 commits Dec 9, 2019
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_17419
0a14185
@terryjreedy
News item.
Loading status checks…
28730b4
@terryjreedy
terryjreedy approved these changes Dec 9, 2019
View changes
Copy link
Member

terryjreedy left a comment

Will merge when CI passes.
@terryjreedy terryjreedy changed the title bpo-38944: Fix Escape key not bound to KeyPress event bpo-38944: Escape key closes IDLE completion windows. Dec 9, 2019
@terryjreedy terryjreedy changed the title bpo-38944: Escape key closes IDLE completion windows. bpo-38944: Escape key now closes IDLE completion windows. Dec 9, 2019
@terryjreedy terryjreedy merged commit 232689b into python:master Dec 9, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191209.45 succeeded
Details
bedevere/issue-number Issue number 38944 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 9, 2019

Thanks @JohnnyNajera for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@JohnnyNajera @miss-islington
bpo-38944: Escape key now closes IDLE completion windows. (pythonGH-1…
1f71307 
…7419)

(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <58344607+JohnnyNajera@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 9, 2019

GH-17546 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 9, 2019

GH-17547 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@JohnnyNajera @miss-islington
bpo-38944: Escape key now closes IDLE completion windows. (pythonGH-1…
9401820 
…7419)

(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <58344607+JohnnyNajera@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @JohnnyNajera
bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b2c7bf 
(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <58344607+JohnnyNajera@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @JohnnyNajera
bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e0e452 
(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <58344607+JohnnyNajera@users.noreply.github.com>
@python python deleted a comment from bedevere-bot Dec 10, 2019
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Dec 10, 2019

I deleted the report that 2 test_asyncio tests failed on one of the buildbots. This PR cannot be responsible for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
5 participants
@JohnnyNajera @the-knights-who-say-ni @bedevere-bot @miss-islington @terryjreedy
You can’t perform that action at this time.