Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant #17554

Merged
merged 1 commit into from Dec 10, 2019
Merged

bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant #17554

merged 1 commit into from Dec 10, 2019

Conversation

@vstinner
Copy link
Member

vstinner commented Dec 10, 2019 •
edited by bedevere-bot

Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.

https://bugs.python.org/issue38614
@vstinner
bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant
Loading status checks…
86469fe 
Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.
@vstinner vstinner requested review from 1st1, asvetlov, tiran and python/email-team as code owners Dec 10, 2019
@vstinner vstinner requested a review from pablogsal Dec 10, 2019
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Dec 10, 2019

@pablogsal: That's the first subset of changes to use the new test.support timeout constants.

Previously, PR #16964 added constants and used constants in some places. I reworked PR #16964 to only add constant, and that's the first following PR to use one of these constants. More PRs will follow for the other constants. This PR is restricted to LOOPBACK_TIMEOUT and so should be easier to review.

LOOPBACK_TIMEOUT default value is 5 seconds. This PR increases timeouts in modified tests, it doesn't reduce it.
@pablogsal
pablogsal approved these changes Dec 10, 2019
View changes
Copy link
Member

pablogsal left a comment

LGTM

Previously, PR #16964 added constants and used constants in some places. I reworked PR #16964 to only add constant, and that's the first following PR to use one of these constants. More PRs will follow for the other constants. This PR is restricted to LOOPBACK_TIMEOUT and so should be easier to review.

Thanks for the split, this makes so much easier to review the PR 🎉
@vstinner vstinner merged commit 07871b2 into python:master Dec 10, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191210.24 succeeded
Details
bedevere/issue-number Issue number 38614 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner vstinner deleted the vstinner:loopback_timeout branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@python/email-team email-team

@1st1 1st1

@asvetlov asvetlov

@tiran tiran

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.