Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38614: Use support timeout constants #17572

Merged
merged 1 commit into from Dec 11, 2019
Merged

bpo-38614: Use support timeout constants #17572

merged 1 commit into from Dec 11, 2019
+67 −36

Conversation

@vstinner
Copy link
Member

vstinner commented Dec 11, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue38614
@vstinner vstinner added the skip news label Dec 11, 2019
@vstinner vstinner requested a review from python/email-team as a code owner Dec 11, 2019
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Dec 11, 2019

Ooops, test_socket failed:

testFamily (test.test_socket.NetworkConnectionAttributesTest) ... Warning -- Unraisable exception

Exception ignored in thread started by: <bound method ThreadableTest.clientRun of <test.test_socket.NetworkConnectionAttributesTest testMethod=testFamily>>

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_socket.py", line 379, in clientRun

    self.clientTearDown()

  File "/home/travis/build/python/cpython/Lib/test/test_socket.py", line 5056, in clientTearDown

    self.cli.close()

AttributeError: 'NetworkConnectionAttributesTest' object has no attribute 'cli'
@vstinner
bpo-38614: Use support timeout constants
Loading status checks…
d952022
@vstinner vstinner force-pushed the vstinner:more_timeouts branch from 34380ac to d952022 Dec 11, 2019
@vstinner vstinner merged commit 7772b1a into python:master Dec 11, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191211.9 succeeded
Details
bedevere/issue-number Issue number 38614 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner vstinner deleted the vstinner:more_timeouts branch Dec 11, 2019
sthagen added a commit to sthagen/cpython that referenced this pull request Dec 11, 2019
@sthagen
Merge pull request #93 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
84595ef 
bpo-38614: Use support timeout constants (pythonGH-17572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/email-team email-team

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.