Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.5] bpo-34155: Dont parse domains containing @ (GH-13079) #15317
+37
−1
Conversation
Before:
>>> email.message_from_string('From: a@malicious.org@important.com', policy=email.policy.default)['from'].addresses
(Address(display_name='', username='a', domain='malicious.org'),)
>>> parseaddr('a@malicious.org@important.com')
('', 'a@malicious.org')
After:
>>> email.message_from_string('From: a@malicious.org@important.com', policy=email.policy.default)['from'].addresses
(Address(display_name='', username='', domain=''),)
>>> parseaddr('a@malicious.org@important.com')
('', 'a@')
https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)
Co-authored-by: jpic <jpic@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
This needs a review from the 3.5 RM if this is going to be backported. |
This comment has been minimized.
This comment has been minimized.
|
@larryhastings: Would you mind to merge this security fix? |
larryhastings
merged commit 063eba2
into
python:3.5
5 checks passed
5 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Sep 7, 2019
|
@larryhastings: Please replace |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the backport and the 3.5 love! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
maxking commentedAug 17, 2019
•
edited by bedevere-bot
Before:
https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)
Co-authored-by: jpic jpic@users.noreply.github.com
https://bugs.python.org/issue34155