Skip to content

bpo-38526: Fix zipfile.Path method name to be the correct one #17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

bpo-38526: Fix zipfile.Path method name to be the correct one #17317

merged 1 commit into from
Nov 21, 2019

Conversation

PCManticore
Copy link
Contributor

@PCManticore PCManticore commented Nov 21, 2019 •
edited by bedevere-bot
Loading

Super minor one, fixes a correct method name in documentation. zipfile.Path.listdir does not actually exist, but there is zipfile.Path.iterdir which seems to be what was originally intentioned.

https://bugs.python.org/issue38526

https://bugs.python.org/issue38526

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 21, 2019
tirkarthi
tirkarthi approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

corona10
corona10 reviewed Nov 21, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PCManticore Thanks for the contribution to CPython.
PR looks good to me also.

@corona10 corona10 requested a review from jaraco November 21, 2019 15:39
@corona10
Copy link
Member

@jaraco

@jaraco jaraco merged commit 65444cf into python:master Nov 21, 2019
@bedevere-bot
Copy link

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @PCManticore for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @PCManticore for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@PCManticore @miss-islington
bpo-38526: Fix zipfile.Path method name to be the correct one (python…
f213d4c 
…GH-17317)

(cherry picked from commit 65444cf)

Co-authored-by: Claudiu Popa <pcmanticore@gmail.com>
@bedevere-bot
Copy link

GH-17329 is a backport of this pull request to the 3.8 branch.

@jaraco
Copy link
Member

jaraco commented Nov 21, 2019

Thanks for putting this together.

miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @PCManticore
bpo-38526: Fix zipfile.Path method name to be the correct one (GH-17317)
107ed88 
(cherry picked from commit 65444cf)

Co-authored-by: Claudiu Popa <pcmanticore@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@PCManticore
bpo-38526: Fix zipfile.Path method name to be the correct one (python…
d8ba008 
…#17317)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@PCManticore @shihai1991
bpo-38526: Fix zipfile.Path method name to be the correct one (python…
a99c1d7 
…#17317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PCManticore @corona10 @bedevere-bot @miss-islington @jaraco @tirkarthi @the-knights-who-say-ni