Skip to content

bpo-38130: Fix error in explaining when an exception is re-raised #16016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2019
Merged

bpo-38130: Fix error in explaining when an exception is re-raised #16016

merged 2 commits into from
Sep 26, 2019

Conversation

prodehghan
Copy link
Contributor

@prodehghan prodehghan commented Sep 12, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mdunicorn

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 12, 2019
@matrixise matrixise self-assigned this Sep 12, 2019
epicfaace
epicfaace reviewed Sep 13, 2019
View reviewed changes
@prodehghan @epicfaace
We won't necessarily have multiple 'except' clauses
8021362 
Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
@matrixise
Copy link
Member

Thank you for your PR, I am going to merge into master, 3.8 and 3.7

@matrixise matrixise merged commit 1ad7be2 into python:master Sep 26, 2019
@miss-islington
Copy link
Contributor

Thanks @mdunicorn for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16415 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16416 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2019
@prodehghan @miss-islington
bpo-38130: Fix error in explaining when an exception is re-raised (py…
50a3e17 
…thonGH-16016)

Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
(cherry picked from commit 1ad7be2)

Co-authored-by: Mohammad Dehghan <md.unicorn@gmail.com>
matrixise pushed a commit that referenced this pull request Sep 26, 2019
@miss-islington @prodehghan @matrixise
bpo-38130: Fix error in explaining when an exception is re-raised (GH…
5017a64 
…-16016) (GH-16416)

Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
(cherry picked from commit 1ad7be2)

Co-authored-by: Mohammad Dehghan <md.unicorn@gmail.com>
matrixise pushed a commit that referenced this pull request Sep 26, 2019
@miss-islington @prodehghan @matrixise
bpo-38130: Fix error in explaining when an exception is re-raised (GH…
68040ed 
…-16016) (GH-16415)

Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
(cherry picked from commit 1ad7be2)

Co-authored-by: Mohammad Dehghan <md.unicorn@gmail.com>
@prodehghan prodehghan deleted the fix-tutorials-errors branch October 12, 2019 22:33
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@prodehghan @epicfaace
bpo-38130: Fix error in explaining when an exception is re-raised (py…
3b774b2 
…thonGH-16016)

Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace left review comments

@matrixise matrixise matrixise approved these changes

Assignees

@matrixise matrixise

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prodehghan @the-knights-who-say-ni @matrixise @miss-islington @bedevere-bot @epicfaace