Skip to content

[3.8] bpo-38979: fix ContextVar "__class_getitem__" method (GH-17497) #17505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.8] bpo-38979: fix ContextVar "__class_getitem__" method (GH-17497) #17505

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 8, 2019 •
edited by bedevere-bot
Loading

now contextvars.ContextVar "class_getitem" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR 31338382+amiremohamadi@users.noreply.github.com

https://bugs.python.org/issue38979

@amiremohamadi @miss-islington
bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)
ae7ba6f 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>
@miss-islington miss-islington requested a review from 1st1 as a code owner December 8, 2019 11:36
@bedevere-bot bedevere-bot mentioned this pull request Dec 8, 2019
Merged
@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@asvetlov asvetlov closed this Dec 8, 2019
@asvetlov asvetlov reopened this Dec 8, 2019
@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

2 similar comments
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@miss-islington miss-islington deleted the backport-28c9163-3.8 branch December 8, 2019 12:24
@miss-islington
Copy link
Contributor Author

@amiremohamadi: Status check is done, and it's a failure ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @asvetlov @the-knights-who-say-ni @bedevere-bot @amiremohamadi