Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some mercurial/ hg.python.org references. #8

Merged
merged 1 commit into from Feb 16, 2017

Conversation

orsenthil
Copy link
Member

@orsenthil orsenthil commented Feb 10, 2017

No description provided.

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 11, 2017

You may also update:

Lib/idlelib/help.html:93:<p><strong>Source code:</strong> <a class="reference external" href="https://hg.python.org/cpython/file/3.5/Lib/idlelib/">Lib/idlelib/</a></p>
Tools/README:46:(*) A generic benchmark suite is maintained separately at http://hg.python.org/benchmarks/
Tools/importbench/README:6:hg.python.org/benchmarks.

For benchmarks, please point to the new project: https://github.com/python/performance

By the way, you might use reST syntax for links to enhance formatting.

@@ -222,7 +222,7 @@ releases are announced on the comp.lang.python and comp.lang.python.announce
newsgroups and on the Python home page at https://www.python.org/; an RSS feed of
news is available.

You can also access the development version of Python through Mercurial. See
You can also access the development version of Python through Git. See
https://docs.python.org/devguide/faq.html for details.

Copy link
Member

@Mariatta Mariatta Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devguide URL should be updated to http://cpython-devguide.readthedocs.io.
Also, the FAQ has been removed from the Dev Guide, so the section you want is perhaps http://cpython-devguide.readthedocs.io/communication.html

Copy link
Member

@zware zware Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/devguide is still correct, but the lack of faq does need to be fixed. Perhaps just remove the /faq.html part.

Copy link
Member

@methane methane Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one correct URL is better.
At least, https://docs.python.org/devguide doesn't switched to github version yet.

Copy link
Member

@Mariatta Mariatta Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update:
https://docs.python.org/devguide has been updated to github.

At the moment /faq.html is still alive, but will be removed soon (see python/devguide#114)

Let's remove the reference to faq.html here :)

@codecov
Copy link

@codecov codecov bot commented Feb 16, 2017

Codecov Report

Merging #8 into master will decrease coverage by -1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   83.39%   82.37%   -1.03%     
==========================================
  Files        1367     1427      +60     
  Lines      344829   350948    +6119     
==========================================
+ Hits       287563   289083    +1520     
- Misses      57266    61865    +4599

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4601c...6d50dde. Read the comment docs.

@orsenthil
Copy link
Member Author

@orsenthil orsenthil commented Feb 16, 2017

Thanks for the review comments, @Haypo , @Mariatta . I've addressed them

  • I saw only .rst page and restructured, the link
  • We have an opportunity in another PR to .rst the other README's that we maintain the library directory. I'll let this PR just a changing references of hg.python.org to the github repo.

Please review again, if good to go, I am willing to try our merge process with merging this to master and cherrying pick to other active branches.

Thanks!

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Looks good to me. Note that you probably should use needs backport to X.Y labels instead of cherry-pick for X.Y.

@orsenthil orsenthil merged commit b2ee40e into python:master Feb 16, 2017
1 check passed
@orsenthil
Copy link
Member Author

@orsenthil orsenthil commented Feb 16, 2017

Thanks @berkerpeksag for your review.

orsenthil referenced this issue in orsenthil/cpython Feb 20, 2017
orsenthil referenced this issue in orsenthil/cpython Feb 20, 2017
orsenthil referenced this issue in orsenthil/cpython Feb 20, 2017
orsenthil added a commit that referenced this issue Feb 20, 2017
orsenthil added a commit that referenced this issue Feb 20, 2017
orsenthil added a commit that referenced this issue Feb 20, 2017
@methane
Copy link
Member

@methane methane commented Feb 22, 2017

ref:

paulmon added a commit to paulmon/cpython that referenced this issue Jan 10, 2019
ethanhs added a commit to ethanhs/cpython that referenced this issue Feb 5, 2020
tiran referenced this issue in tiran/cpython Nov 18, 2020
Direct leak of 57 byte(s) in 1 object(s) allocated from:

    #0 0x7fa6397cc667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    #1 0x777579 in PyUnicode_New Objects/unicodeobject.c:1459
    #2 0x86aa4e in unicode_decode_utf8 Objects/unicodeobject.c:5129
    #3 0x8b6050 in PyUnicode_DecodeUTF8Stateful Objects/unicodeobject.c:5259
    #4 0x8b6050 in PyUnicode_FromString Objects/unicodeobject.c:2311
    #5 0x8b6050 in PyUnicode_InternFromString Objects/unicodeobject.c:15788
    #6 0x8f1e0b in create_filter Python/_warnings.c:67
    #7 0x8f1e0b in init_filters Python/_warnings.c:95
    #8 0x8f1e0b in _PyWarnings_InitState Python/_warnings.c:123
    python#9 0xa52178 in pycore_init_types Python/pylifecycle.c:704
    python#10 0xa52178 in pycore_interp_init Python/pylifecycle.c:760
    python#11 0xa5eab1 in pyinit_config Python/pylifecycle.c:807
    python#12 0xa5eab1 in pyinit_core Python/pylifecycle.c:970
    python#13 0xa60037 in Py_InitializeFromConfig Python/pylifecycle.c:1155
    python#14 0x47a842 in pymain_init Modules/main.c:66
    python#15 0x4802a2 in pymain_main Modules/main.c:698
    python#16 0x4802a2 in Py_BytesMain Modules/main.c:731
    python#17 0x7fa638a5b041 in __libc_start_main (/lib64/libc.so.6+0x27041)

Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants