Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-38379: don't claim objects are collected when they aren't (GH-16658) #16683

Merged
merged 1 commit into from Oct 9, 2019
Merged

[3.8] bpo-38379: don't claim objects are collected when they aren't (GH-16658) #16683

merged 1 commit into from Oct 9, 2019

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 9, 2019 •
edited

  • bpo-38379: when a finalizer resurrects an object,
    nothing is actually collected in this run of gc.
    Change the stats to relect that truth.
    (cherry picked from commit ecbf35f)

Co-authored-by: Tim Peters tim.peters@gmail.com

https://bugs.python.org/issue38379

Automerge-Triggered-By: @pablogsal
@tim-one @pablogsal
[3.8] bpo-38379: don't claim objects are collected when they aren't (p…
bef43ac 
…ythonGH-16658)

* bpo-38379:  when a finalizer resurrects an object,
nothing is actually collected in this run of gc.
Change the stats to relect that truth.
(cherry picked from commit ecbf35f)

Co-authored-by: Tim Peters <tim.peters@gmail.com>
@pablogsal pablogsal requested a review from tim-one Oct 9, 2019
@bedevere-bot bedevere-bot mentioned this pull request Oct 9, 2019
Merged
tim-one
tim-one approved these changes Oct 9, 2019
View changes
Copy link
Member

@tim-one tim-one left a comment

This looks familiar 😉 Thank you! Will you do the same for 3.7?

@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Oct 9, 2019

This looks familiar wink Thank you! Will you do the same for 3.7?

Here you go:

#16685

:)

@pablogsal pablogsal changed the title [3.8] bpo-38379: don't claim objects are collected when they aren't … [3.8] bpo-38379: don't claim objects are collected when they aren't (GH-16658) Oct 9, 2019
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 9, 2019

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0bd9fac into python:3.8 Oct 9, 2019
5 checks passed
@pablogsal pablogsal deleted the backport-ecbf35f-3.8 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-one tim-one

Assignees
No one assigned
Labels
CLA signed 🤖 automerge
Projects
None yet
Milestone
No milestone
5 participants
@pablogsal @miss-islington @tim-one @the-knights-who-say-ni @bedevere-bot