bpo-34794: Fix a leak in Tkinter. #10025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
type-bug
zhangyangyu
approved these changes
Oct 21, 2018
|
@serhiy-storchaka: Hum, it seems like this fix can be merged, but it seems like you prefer to merge your own PRs :-) |
|
Thank you @vstinner and @zhangyangyu. |
|
Actually it is @zhangyangyu have found the bug. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2018
Based on the investigation by Xiang Zhang. (cherry picked from commit df13df4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2018
Based on the investigation by Xiang Zhang. (cherry picked from commit df13df4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-10069 is a backport of this pull request to the 3.7 branch. |
|
GH-10070 is a backport of this pull request to the 3.6 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Oct 23, 2018
vstinner
pushed a commit
that referenced
this pull request
Oct 23, 2018
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 28, 2018
Based on the investigation by Xiang Zhang.. (cherry picked from commit df13df4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-10181 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34794