Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typo] fix dupe in datetime.fromisoformat docs #17295

Merged
merged 1 commit into from Dec 23, 2019
Merged

[typo] fix dupe in datetime.fromisoformat docs #17295

merged 1 commit into from Dec 23, 2019
+0 −2

Conversation

@yawpitch
Copy link
Contributor

yawpitch commented Nov 20, 2019 •
edited by miss-islington

Fixes a nearly word for word duplication of a sentence that appears
earlier in the caution section of datetime.datetime.fromisoformat in
Doc/Library/datetime.rst.

No issue created as it's a trivial change.

Automerge-Triggered-By: @pganssle
@yawpitch
[typo] fix dupe in datetime.fromisoformat docs
Verified
This commit was signed with a verified signature.
yawpitch Michael Morehouse
GPG key ID: EB17AF4E38DAAAFF Learn about signing commits
Loading status checks…
f83f862 
Fixes a near word for word duplication of a sentence that appears
earlier in the caution section for datetime.datetime.fromisoformat in
Doc/Library/datetime.rst.

No issue created as it's a trivial fix.
@yawpitch yawpitch requested review from abalkin and pganssle as code owners Nov 20, 2019
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Nov 20, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@yawpitch

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@pganssle
pganssle approved these changes Nov 20, 2019
View changes
@pganssle

This comment has been minimized.

Sign in to view
Copy link
Member

pganssle commented Nov 20, 2019

@yawpitch Thanks for noticing and submitting the PR. Your contribution is appreciated!

I can merge this once you have signed the CLA. 😄
@yawpitch

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

yawpitch commented Nov 20, 2019

@pganssle no problem; the CLA has been signed and submitted, just need to wait for the USA to catch up to the UK. 😉
@pganssle

This comment has been minimized.

Sign in to view
Copy link
Member

pganssle commented Nov 20, 2019

Interestingly, this appears in the 3.8 version of the documentation but not the 3.7 version, even though the 3.7 documentation has the newer wording that mentions dateutil. Seems like this may be the result of a bad merge or something, I'll have to check the relevant PRs.
@pganssle pganssle removed the request for review from abalkin Nov 20, 2019
@pganssle pganssle mentioned this pull request Nov 26, 2019
Closed
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor

csabella commented Dec 13, 2019

@yawpitch, thank you for the contribution. It appears that the bot isn't able to find the signed CLA yet. Can you check it again to make sure it matches to Github? Thanks!
@yawpitch

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

yawpitch commented Dec 13, 2019

@csabella that's weird ... I've tried signing again using my more normal email address, but I've now got a signed CLA in my inbox for both the email address I use on the bugs.python.org site and the one that is my (private) email on Github.

I'm wondering if the fact that I've got my email set to "private" on Github has anything to do with it?

Does the automated check not just use my username?
@miss-islington miss-islington merged commit e7b406f into python:master Dec 23, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191120.47 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 23, 2019

Thanks @yawpitch for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 23, 2019
@yawpitch @miss-islington
[typo] fix dupe in datetime.fromisoformat docs (pythonGH-17295)
646f241 
Fixes a nearly word for word duplication of a sentence that appears
earlier in the caution section of datetime.datetime.fromisoformat in
Doc/Library/datetime.rst.

No issue created as it's a trivial change.

Automerge-Triggered-By: @pganssle
(cherry picked from commit e7b406f)

Co-authored-by: Michael Morehouse <640167+yawpitch@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 23, 2019

GH-17686 is a backport of this pull request to the 3.8 branch.
@pganssle

This comment has been minimized.

Sign in to view
Copy link
Member

pganssle commented Dec 23, 2019

Thanks for your patience @yawpitch. I asked @ewdurbin about this and he said that when he checked the CLA status at the link from the bot, it triggered the bot to update the label (though I guess that's not a problem you will have again).

Thanks again for your contribution!
miss-islington added a commit that referenced this pull request Dec 23, 2019
@miss-islington @yawpitch
[typo] fix dupe in datetime.fromisoformat docs (GH-17295)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a542aec 
Fixes a nearly word for word duplication of a sentence that appears
earlier in the caution section of datetime.datetime.fromisoformat in
Doc/Library/datetime.rst.

No issue created as it's a trivial change.

Automerge-Triggered-By: @pganssle
(cherry picked from commit e7b406f)

Co-authored-by: Michael Morehouse <640167+yawpitch@users.noreply.github.com>
@yawpitch yawpitch deleted the yawpitch:fix-fromisoformat-doc-dupe branch Dec 23, 2019
@yawpitch

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

yawpitch commented Dec 23, 2019

@pganssle no problem at all, just a little docfix. Thanks for following up on it! M
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle

Assignees
No one assigned
Labels
🤖 automerge CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@yawpitch @the-knights-who-say-ni @pganssle @csabella @miss-islington @bedevere-bot
You can’t perform that action at this time.