Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39041: Add GitHub Actions support #17594
Conversation
zooba
changed the title
|
Should make sure to add doc-building workflow. I would also build against |
This comment has been minimized.
This comment has been minimized.
|
I changed the VM images to "latest", but it still seems best to have static labels. I also added the coverage test run after we know the Ubuntu tests have passed, but I don't know that we'll want the extra delay. Maybe if I split it into a separate check we can make the coverage run optional? We'll have to merge this one first though. Once I get the docs workflow in then we can do that and iterate on the coverage run. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I would split the coverage run out as a separate thing as we don't rely on it to prevent coverage slippage. |
This comment has been minimized.
This comment has been minimized.
|
From my other PR (where I've enabled the builds), it looks like this: |
zooba commentedDec 13, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39041