New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39080: Starred Expression's column offset fix when inside a CALL #17645

Open

lysnikolaou wants to merge 4 commits into python:master from lysnikolaou:starred-expr-col

+11 −1

Contributor

lysnikolaou commented Dec 17, 2019 •

edited by bedevere-bot

https://bugs.python.org/issue39080


        Starred Expression's column offset fix when inside a CALL

dc1efbc

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label


        📜🤖 Added by blurb_it.

d9c0054

lysnikolaou mentioned this pull request

Simpy refactorings: class_def and arguments #122

Open


        Update eval_tests

05a2fca

pablogsal reviewed

Misc/NEWS.d/next/Core and Builtins/2019-12-17-21-45-36.bpo-39080.OrxEVS.rst Outdated Show resolved Hide resolved


        Update Misc/NEWS.d/next/Core and Builtins/2019-12-17-21-45-36.bpo-39080…

9f37e4b

….OrxEVS.rst

Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>

lysnikolaou requested a review from pablogsal

Member

pablogsal commented Dec 17, 2019

Actually, this seems that does not only affect starred expressions. For example:

>>> val = "f(a,b,c)"
>>> val[ast.parse(val).body[0].value.args[2].end_col_offset]
')'
>>> val[ast.parse(val).body[0].value.args[0].end_col_offset]
','
>>> val[ast.parse(val).body[0].value.args[1].end_col_offset]
','
>>> val[ast.parse(val).body[0].value.args[2].end_col_offset]
')'

that seems odd.

Member

gvanrossum commented Dec 17, 2019

Possibly @ilevkivskyi would also be interested in hearing about this?

pablogsal requested a review from ilevkivskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.