Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.6] Doc: Add an optional obsolete header. (GH-13638). #13657
Conversation
This comment has been minimized.
This comment has been minimized.
|
@ned-deily Hi Ned, would you please merge this, if you like it? See screenshot here: #13638 |
|
Are you also planning to add |
| <div id="outdated-warning" style="padding: .5em; text-align: center; background-color: #FFBABA; color: #6A0E0E;"> | ||
| {% trans %}This document is for an old version of Python that is no longer supported. | ||
| You should upgrade, and read the {% endtrans %} | ||
| <a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the last stable release {% endtrans %}</a>. |
This comment has been minimized.
This comment has been minimized.
ned-deily
May 30, 2019
Member
Suggest using "most recent" or "current" rather than "last" to avoid ambiguity ("most recent" vs "final").
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
May 30, 2019
|
When you're done making the requested changes, leave the comment: |
This comment has been minimized.
This comment has been minimized.
I think I'll add it thrue docsbuild-scripts, not via the file, so for future releases I won't have to commit the boolean to conf.py. |
This comment has been minimized.
This comment has been minimized.
|
I have made the requested changes; please review again. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jun 15, 2019
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
|
LGTM, thanks! |
ned-deily
merged commit 78309c9
into
python:3.6
JulienPalard commentedMay 29, 2019
(cherry picked from commit 46ed90d)
Co-authored-by: Julien Palard julien@palard.fr