Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. #17620
Conversation
…ed-words. In certain malformed content-disposition headers, parameter values are quoted and split as encoded words on two lines with extra whitespaces. This fixes the issue by removing the extra whitespace between the two encoded words.
Misc/NEWS.d/next/Library/2019-12-15-18-47-20.bpo-39040.tKa0Qs.rst
Outdated
Show resolved
Hide resolved
Oops, I forgot to start a review :( |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 16, 2019
When you're done making the requested changes, leave the comment: |
This comment has been minimized.
This comment has been minimized.
I have made the requested changes; please review again. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 17, 2019
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
[], | ||
'attachment; filename="File Name With Spaces.pdf"', | ||
('Content-Disposition: attachment; ' | ||
'filename="File Name With Spaces.pdf"\n'), |
This comment has been minimized.
This comment has been minimized.
bitdancer
Dec 17, 2019
Member
Not quite. We need a test with something like "File =?utf-8?q?Name?= With Spaces.pdf". That should have spaces around Name...we want to make sure we aren't removing spaces around encoded words that aren't next to other encoded words.
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 17, 2019
When you're done making the requested changes, leave the comment: |
maxking commentedDec 16, 2019
•
edited by bedevere-bot
In certain malformed content-disposition headers, parameter values are quoted
and split as encoded words on two lines with extra whitespaces. This fixes the
issue by removing the extra whitespace between the two encoded words.
https://bugs.python.org/issue39040