Skip to content

[3.8] bpo-39031: Include elif keyword when producing lineno/col-offset info for if_stmt (GH-17582) #17583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.8] bpo-39031: Include elif keyword when producing lineno/col-offset info for if_stmt (GH-17582) #17583

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 12, 2019 •
edited by bedevere-bot
Loading

When parsing an "elif" node, lineno and col_offset of the node now point to the "elif" keyword and not to its condition, making it consistent with the "if" node.

https://bugs.python.org/issue39031

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 025a602)

Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com

https://bugs.python.org/issue39031

@lysnikolaou @miss-islington
bpo-39031: Include elif keyword when producing lineno/col-offset info…
8653b28 
… for if_stmt (pythonGH-17582)

When parsing an "elif" node, lineno and col_offset of the node now point to the "elif" keyword and not to its condition, making it consistent with the "if" node.

https://bugs.python.org/issue39031

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 025a602)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 12, 2019
Merged
@miss-islington
Copy link
Contributor Author

@lysnikolaou: Status check is done, and it's a failure ❌ .

@pablogsal
Copy link
Member

@brettcannon It seems we have again a similar problem with Travis and pyenv on the maintainance backports (affects both 3.8 and `3.7). Could we make it not required again on these branches? Or there is something we can do to fix it?

@pablogsal
Copy link
Member

The error in 3.8 looks like this (for reference):

pyenv: python3.8: command not found
pyenv: python3.8: command not found
pyenv: python3.8: command not found
pyenv: python3.8: command not found
The `python3.8' command exists in these Python versions:
  3.8
  3.8.0

@gvanrossum
Copy link
Member

Hm, why are we using pyenv? That seems a dependency reversal.

@brettcannon
Copy link
Member

@gvanrossum I think it's because Travis uses it to install specific versions of Python.

@pablogsal done

@brettcannon brettcannon reopened this Dec 13, 2019
@miss-islington
Copy link
Contributor Author

@lysnikolaou: Status check is done, and it's a failure ❌ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@lysnikolaou: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@lysnikolaou: Status check is done, and it's a failure ❌ .

@miss-islington miss-islington deleted the backport-025a602-3.8 branch December 13, 2019 00:55
@miss-islington
Copy link
Contributor Author

@lysnikolaou: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@lysnikolaou: Status check is done, and it's a failure ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miss-islington @pablogsal @gvanrossum @brettcannon @the-knights-who-say-ni @bedevere-bot @lysnikolaou