Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] bpo-39084: Construct string.letters in the correct order when resetting locale #17650

Open
wants to merge 1 commit into
base: 2.7
from
Open

[2.7] bpo-39084: Construct string.letters in the correct order when resetting locale #17650

wants to merge 1 commit into from
+11 −16

Conversation

@Manishearth
Copy link

Manishearth commented Dec 18, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue39084
@Manishearth
bpo-39084: Construct string.letters in the correct order when resetti…
Loading status checks…
6de6b9e 
…ng locale

We are constructing `string.letters` by iterating through all ASCII
letters, looking for `isalpha`, but that will place uppercase letters
first. This change makes the code construct the string in the correct
order (using the same buffer to avoid reiterating).
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Dec 18, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Manishearth

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Author

Manishearth commented Dec 18, 2019

(I've already signed the CLA online, but it hasn't been updated)
@Manishearth Manishearth changed the title bpo-39084: Construct string.letters in the correct order when resetting locale [2.7] bpo-39084: Construct string.letters in the correct order when resetting locale Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA not signed awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@Manishearth @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.