bpo-36433: fix confusing error messages in classmethoddescr_call #12556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
added
type-bug
Objects/descrobject.c
Outdated
| @@ -314,21 +314,20 @@ classmethoddescr_call(PyMethodDescrObject *descr, PyObject *args, | |||
| self = PyTuple_GET_ITEM(args, 0); | |||
| if (!PyType_Check(self)) { | |||
| PyErr_Format(PyExc_TypeError, | |||
| "descriptor '%V' requires a type " | |||
| "but received a '%.100s'", | |||
| "descriptor '%V' requires a subtype of '%.100s' " | |||
There was a problem hiding this comment.
I am not sure that subtype of '%.100s' is better than just type. It contains more information, but I think that this information is redundant at that moment and distracts from the true error -- passing an instance instead of a type.
Maybe just remove PyDescr_TYPE(descr)->tp_name?
Lib/test/test_descr.py
Outdated
| spam_cm() | ||
| with self.assertRaises(TypeError): | ||
| self.assertEqual( | ||
| cm.exception.args[0], |
There was a problem hiding this comment.
It may be better to test str(cm.exception) instead of cm.exception.args[0]. Just for the case if error messages be generated dynamically in the future.
serhiy-storchaka
approved these changes
Mar 26, 2019
|
@methane: Status check is done, and it's a success ✅ . |
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-12557 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 26, 2019
…honGH-12556) https://bugs.python.org/issue36433 (cherry picked from commit 871309c) Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Mar 26, 2019
…12556) https://bugs.python.org/issue36433 (cherry picked from commit 871309c) Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36433