Skip to content

bpo-38255: super() can search attributes as well as methods #16368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2019
Merged

bpo-38255: super() can search attributes as well as methods #16368

merged 1 commit into from
Sep 25, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Sep 25, 2019 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news needs backport to 3.8 labels Sep 25, 2019
@rhettinger rhettinger mentioned this pull request Sep 25, 2019
Closed
eamanu
eamanu approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this PR instead of https://github.com/python/cpython/pull/16331/files. I think is better mention that we can use super() for attribute lookups, and not just change word attribute for methods. I think that could be confuse.

geryogam
geryogam approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@geryogam geryogam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhettinger, I have closed my PR. You can merge.

@rhettinger rhettinger merged commit 15ccc4f into python:master Sep 25, 2019
@rhettinger rhettinger deleted the super_attribute branch September 25, 2019 15:13
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16391 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16392 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2019
@rhettinger @miss-islington
bpo-38255: super() can search attributes as well as methods (pythonGH…
d2671c8 
…-16368)

Improvement suggested by Géry Ogam.
(cherry picked from commit 15ccc4f)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger added a commit that referenced this pull request Sep 25, 2019
@miss-islington @rhettinger
bpo-38255: super() can search attributes as well as methods (GH-16368) (
7444a5a 
GH-16391)

Improvement suggested by Géry Ogam.
(cherry picked from commit 15ccc4f)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger added a commit that referenced this pull request Sep 25, 2019
@miss-islington @rhettinger
bpo-38255: super() can search attributes as well as methods (GH-16368) (
3b5e924 
GH-16392)

Improvement suggested by Géry Ogam.
(cherry picked from commit 15ccc4f)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@rhettinger
bpo-38255: super() can search attributes as well as methods (pythonGH…
4e21e40 
…-16368)

Improvement suggested by Géry Ogam.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@eamanu eamanu eamanu approved these changes

@geryogam geryogam geryogam approved these changes

@freddrake freddrake Awaiting requested review from freddrake

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhettinger @miss-islington @bedevere-bot @willingc @eamanu @geryogam @the-knights-who-say-ni