Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-39033: Fix NameError in zipimport during hash validation (GH-17588) #17642

Open
wants to merge 1 commit into
base: 3.8
from
Open

[3.8] bpo-39033: Fix NameError in zipimport during hash validation (GH-17588) #17642

wants to merge 1 commit into from
+288 −272

Conversation

@tirkarthi
Copy link
Contributor

tirkarthi commented Dec 17, 2019 •
edited by bedevere-bot

Fix NameError in zipimport during hash validation and add a regression test.

(cherry picked from commit 79f02fe)

https://bugs.python.org/issue39033
@tirkarthi
bpo-39033: Fix NameError in zipimport during hash validation (GH-17588)
Loading status checks…
05a9fa9 
Patch by Karthikeyan Singaravelan.

(cherry picked from commit 79f02fe)
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

tirkarthi commented Dec 17, 2019

Attaching steps I followed to create the backport. Verified that reverting to older importlib file causes NameError in test as expected.

$ git checkout -b backport-79f02fe-3.8 upstream/3.8
$ git cherry-pick -x 79f02fee1a542c440fd906fd54154c73fc0f8235
$ git checkout HEAD Python/importlib_zipimport.h # Revert to HEAD and regenerate file to avoid conflicts.
$ make regen-importlib
$ git add -u .
$ git cherry-pick --continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@warsaw warsaw

@encukou encukou

@ncoghlan ncoghlan

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
3 participants
@tirkarthi @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.