Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated logging API in Sphinx #9875

Merged
merged 1 commit into from Oct 15, 2018
Merged

Stop using deprecated logging API in Sphinx #9875

merged 1 commit into from Oct 15, 2018
+6 −4

Conversation

@pablogsal
Copy link
Member

pablogsal commented Oct 14, 2018 •
edited

The doc target can fail due to the use of a deprecated logging API in
Doc/tools/extensions/suspicious.py and treating warnings as errors. Example error:

$ make check suspicious html SPHINXOPTS="-q -W -j4"
python3 tools/rstlint.py -i tools -i ./venv -i README.rst
No problems found.
make[1]: Entering directory `/home/travis/build/python/cpython/Doc'
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b suspicious -d build/doctrees -D latex_elements.papersize= -q -W -j4 . build/suspicious 
/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/sphinx/application.py:402: RemovedInSphinx20Warning: app.info() is now deprecated. Use sphinx.util.logging instead.
  RemovedInSphinx20Warning)
@pablogsal
Stop using deprecated logging API in Sphinx
Verified
This commit was signed with a verified signature.
pablogsal Pablo Galindo
GPG key ID: FFE87404168BD847 Learn about signing commits
Loading status checks…
fa6ad3a
@pablogsal pablogsal force-pushed the pablogsal:fix_sphinx branch from 4bd814a to fa6ad3a Oct 14, 2018
@ned-deily ned-deily requested a review from JulienPalard Oct 15, 2018
@brettcannon
brettcannon approved these changes Oct 15, 2018
View changes
@pablogsal pablogsal merged commit ee171a2 into python:master Oct 15, 2018
5 checks passed
5 checks passed
Azure Pipelines PR #20181014.29 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pablogsal pablogsal deleted the pablogsal:fix_sphinx branch Oct 15, 2018
vstinner added a commit that referenced this pull request Oct 16, 2018
@vstinner
Revert "Stop using deprecated logging API in Sphinx suspicious checker (
0f4cec0 
GH-9875)"

This reverts commit ee171a2.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Oct 18, 2018
@CuriousLearner
Merge branch 'master' into fix-issue8525
c0917e3 
* master: (621 commits)
  Update opcode.h header comment to mention the source data file (pythonGH-9935)
  bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pythonGH-9760)
  Updated documentation on logging.debug(). (pythonGH-9946)
  bpo-34765: Update the install-sh file (pythonGH-9592)
  bpo-35008: Fix possible leaks in Element.__setstate__(). (pythonGH-9924)
  bpo-35011: Restore use of pyexpatns.h in libexpat (pythonGH-9939)
  bpo-24658: Fix read/write greater than 2 GiB on macOS (pythonGH-1705)
  Add missing comma to wsgiref doc (pythonGH-9932)
  bpo-23420: Verify the value of '-s' when execute the CLI of cProfile (pythonGH-9925)
  Doc: Fix is_prime (pythonGH-9909)
  In email docs, correct spelling of foregoing (python#9856)
  In email.parser in message_from_bytes, update `strict` to `policy` (python#9854)
  bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (pythonGH-9913)
  Added CLI starter example to logging cookbook. (pythonGH-9910)
  bpo-34783: Fix test_nonexisting_script() (pythonGH-9896)
  bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (pythonGH-9859)
  bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889)
  Stop using deprecated logging API in Sphinx suspicious checker (pythonGH-9875)
  fix dangling keyfunc examples in documentation of heapq and sorted (python#1432)
  bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter  (pythonGH-9703)
  ...
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Oct 18, 2018
@CuriousLearner
Merge branch 'master' into fix-issue15045
9f75617 
* master: (1787 commits)
  Update opcode.h header comment to mention the source data file (pythonGH-9935)
  bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pythonGH-9760)
  Updated documentation on logging.debug(). (pythonGH-9946)
  bpo-34765: Update the install-sh file (pythonGH-9592)
  bpo-35008: Fix possible leaks in Element.__setstate__(). (pythonGH-9924)
  bpo-35011: Restore use of pyexpatns.h in libexpat (pythonGH-9939)
  bpo-24658: Fix read/write greater than 2 GiB on macOS (pythonGH-1705)
  Add missing comma to wsgiref doc (pythonGH-9932)
  bpo-23420: Verify the value of '-s' when execute the CLI of cProfile (pythonGH-9925)
  Doc: Fix is_prime (pythonGH-9909)
  In email docs, correct spelling of foregoing (python#9856)
  In email.parser in message_from_bytes, update `strict` to `policy` (python#9854)
  bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (pythonGH-9913)
  Added CLI starter example to logging cookbook. (pythonGH-9910)
  bpo-34783: Fix test_nonexisting_script() (pythonGH-9896)
  bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (pythonGH-9859)
  bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889)
  Stop using deprecated logging API in Sphinx suspicious checker (pythonGH-9875)
  fix dangling keyfunc examples in documentation of heapq and sorted (python#1432)
  bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter  (pythonGH-9703)
  ...
yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@pablogsal @yahya-abou-imran
Stop using deprecated logging API in Sphinx suspicious checker (pytho…
5b077c7 
…nGH-9875)
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 9, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 9, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 9, 2019

GH-13923 is a backport of this pull request to the 3.6 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 9, 2019

GH-13924 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019
@pablogsal @miss-islington
Stop using deprecated logging API in Sphinx suspicious checker (pytho…
39ffa42 
…nGH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019
@pablogsal @miss-islington
Stop using deprecated logging API in Sphinx suspicious checker (pytho…
8d9e4ea 
…nGH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 9, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 9, 2019

GH-13925 is a backport of this pull request to the 2.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019
@pablogsal @miss-islington
Stop using deprecated logging API in Sphinx suspicious checker (pytho…
9837e9b 
…nGH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Jun 9, 2019
@miss-islington @pablogsal
Stop using deprecated logging API in Sphinx suspicious checker (GH-9875)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3621bf2 
(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
ned-deily added a commit that referenced this pull request Jun 9, 2019
@miss-islington @pablogsal @ned-deily
Stop using deprecated logging API in Sphinx suspicious checker (GH-9875…
Loading status checks…
9393e19 
…) (GH-13923)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Oct 8, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Oct 8, 2019

Sorry @pablogsal, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ee171a26c1169abfae534b08acc0d95c6e45a22a 2.7
benjaminp added a commit that referenced this pull request Oct 8, 2019
@pablogsal @benjaminp
[2.7] Stop using deprecated logging API in Sphinx suspicious checker (G…
0b6b3ff 
…H-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
benjaminp added a commit that referenced this pull request Oct 8, 2019
@pablogsal @benjaminp
[2.7] Stop using deprecated logging API in Sphinx suspicious checker (G…
Loading status checks…
203abbd 
…H-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
benjaminp added a commit that referenced this pull request Oct 8, 2019
@pablogsal @benjaminp
[2.7] Stop using deprecated logging API in Sphinx suspicious checker (G…
Loading status checks…
1aba570 
…H-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
benjaminp added a commit that referenced this pull request Oct 8, 2019
@pablogsal @benjaminp
[2.7] Stop using deprecated logging API in Sphinx suspicious checker (G…
Loading status checks…
86971d4 
…H-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@JulienPalard JulienPalard

Assignees

@pablogsal pablogsal

Labels
CLA signed needs backport to 2.7 skip issue skip news
Projects
None yet
Milestone
No milestone
7 participants
@pablogsal @miss-islington @bedevere-bot @brettcannon @benjaminp @ned-deily @the-knights-who-say-ni
You can’t perform that action at this time.