New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38870: Remove dead code related with argument unparsing #17613

Merged

pablogsal merged 2 commits into python:master from isidentical:bpo-38870-refactors

Dec 16, 2019

+2 −5

Contributor

isidentical commented Dec 15, 2019 •

edited by bedevere-bot

It looks like there are no ways this code to fall down first = False block. Because of this statement;

cpython/Lib/ast.py

Lines 1187 to 1189 in 94d2c8d

    
           if node.vararg or node.kwonlyargs: 
        
               if first: 
        
                   first = False

https://bugs.python.org/issue38870


        bpo-38870: Remove dead code related with argument unparsing

450469c

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label

pablogsal requested changes

Misc/NEWS.d/next/Library/2019-12-15-15-22-04.bpo-38870.YHJpq5.rst Outdated

  
      @@ -0,0 +1 @@
    
        Remove dead code from ``ast._Unparser`` related with argument unparsing.

pablogsal Dec 15, 2019

Member

Please, remove the NEWS entry. There is no user-facing change here :)

bedevere-bot added awaiting changes and removed awaiting review labels

bedevere-bot commented Dec 15, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.


        remove news entry

49d402f

Contributor Author

isidentical commented Dec 16, 2019

I have made the requested changes; please review again

bedevere-bot added awaiting change review and removed awaiting changes labels

bedevere-bot commented Dec 16, 2019

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

bedevere-bot requested a review from pablogsal

bedevere-bot commented Dec 16, 2019

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

pablogsal added the skip news label

Member

pablogsal commented Dec 16, 2019 •

edited

Disregard my latest message, I was looking at the wrong branch! (Reviewing on the phone is a suboptimal experience) 😂

pablogsal merged commit a322f50 into python:master

4 checks passed

4 checks passed

Azure Pipelines PR #20191216.3 succeeded

Details

bedevere/issue-number Issue number 38870 found

Details

bedevere/news "skip news" label found

continuous-integration/travis-ci/pr The Travis CI build passed

Details

bedevere-bot removed the awaiting change review label

Member

pablogsal commented Dec 16, 2019

Thanks for the PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.