Skip to content

[2.7] bpo-30134: fix BytesWarning doc, docstring and message #12739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2019
Merged

[2.7] bpo-30134: fix BytesWarning doc, docstring and message #12739

merged 4 commits into from
Apr 9, 2019

Conversation

methane
Copy link
Member

@methane methane commented Apr 9, 2019 •
edited by bedevere-bot
Loading

@methane methane requested a review from serhiy-storchaka April 9, 2019 07:08
@methane methane changed the title bpo-30134: fix docstring and message of BytesWarning [2.7] bpo-30134: fix docstring and message of BytesWarning Apr 9, 2019
serhiy-storchaka
serhiy-storchaka reviewed Apr 9, 2019
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix also a comment in pythonrun.c:
/* Warn on comparison between bytearray and unicode */

@methane methane changed the title [2.7] bpo-30134: fix docstring and message of BytesWarning [2.7] bpo-30134: fix BytesWarning doc, docstring and message Apr 9, 2019
@methane methane merged commit 4e8e8aa into python:2.7 Apr 9, 2019
@methane methane deleted the fix-byteswarning branch April 9, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot