Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #13426

Merged
merged 2 commits into from Jun 15, 2019
Merged

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #13426

merged 2 commits into from Jun 15, 2019

Conversation

@tirkarthi
Copy link
Member

@tirkarthi tirkarthi commented May 19, 2019 •
edited by bedevere-bot

This is a manual backport of ca7fe50 since 2.7 has http.cookiejar in cookielib

https://bugs.python.org/issue35121
tirkarthi added 2 commits May 19, 2019
@tirkarthi
Prefix dot in domain for proper subdomain validation
def9e64
@tirkarthi
Add NEWS entry
Loading status checks…
f16d631
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 19, 2019
@bedevere-bot bedevere-bot added the awaiting review label May 19, 2019
@tirkarthi
Copy link
Member Author

@tirkarthi tirkarthi commented May 19, 2019

Requesting review from @benjaminp since this is a manual backport of the security fix in 3.x branch
@tirkarthi tirkarthi closed this May 19, 2019
@tirkarthi tirkarthi reopened this May 19, 2019
@tirkarthi
Copy link
Member Author

@tirkarthi tirkarthi commented Jun 15, 2019

@serhiy-storchaka @orsenthil @alex Would be helpful to have your review of this security backport to 2.7 branch.
@alex alex changed the title [2.7] bpo-35121: prefix dot in domain for proper subdomain validation [2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) Jun 15, 2019
@bedevere-bot bedevere-bot added the type-security label Jun 15, 2019
@alex
alex approved these changes Jun 15, 2019
View changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 15, 2019
@alex alex added the 🤖 automerge label Jun 15, 2019
@miss-islington miss-islington merged commit 979daae into python:2.7 Jun 15, 2019
5 checks passed
5 checks passed
bedevere/issue-number Issue number 35121 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 15, 2019
@tirkarthi
Copy link
Member Author

@tirkarthi tirkarthi commented Jun 15, 2019

Thank you @alex :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex

Assignees
No one assigned
Labels
🤖 automerge CLA signed type-security
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@tirkarthi @alex @the-knights-who-say-ni @bedevere-bot @miss-islington