Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34523: Fix C locale coercion on FreeBSD CURRENT #10672

Merged
merged 2 commits into from Nov 23, 2018
Merged

bpo-34523: Fix C locale coercion on FreeBSD CURRENT #10672

merged 2 commits into from Nov 23, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 23, 2018 •
edited by bedevere-bot

bpo-34523, bpo-35290: C locale coercion now resets the Python
internal "force ASCII" mode. This change fix the filesystem encoding
on FreeBSD CURRENT which has a new "C.UTF-8" locale.

  • Add _Py_ResetForceASCII()
  • _coerce_default_locale_settings() now calls _Py_ResetForceASCII()

https://bugs.python.org/issue34523

@vstinner
bpo-34523: Fix C locale coercion on FreeBSD CURRENT
0a94494 
bpo-34523, bpo-35290: C locale coercion now resets the Python
internal "force ASCII" mode. This change fix the filesystem encoding
on FreeBSD CURRENT which has a new "C.UTF-8" locale.

Add _Py_ResetForceASCII(). _Py_SetLocaleFromEnv() now calls
_Py_ResetForceASCII().
@vstinner
define _Py_ResetForceASCII() on Windows
b593de2 
On Windows, the function does nothing.
@vstinner vstinner merged commit 353933e into python:master Nov 23, 2018
@vstinner vstinner deleted the reset_ascii branch Nov 23, 2018
vstinner added a commit that referenced this pull request Nov 23, 2018
@vstinner
bpo-34523: Fix C locale coercion on FreeBSD CURRENT (GH-10672) (GH-10673
f6e323c 
)

bpo-34523, bpo-35290: C locale coercion now resets the Python
internal "force ASCII" mode. This change fix the filesystem encoding
on FreeBSD CURRENT, which has a new "C.UTF-8" locale, when
the UTF-8 mode is disabled.

Add _Py_ResetForceASCII(): _Py_SetLocaleFromEnv() now calls it.

(cherry picked from commit 353933e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot