Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Include/objimpl.h #5568

Merged
merged 1 commit into from Feb 6, 2018
Merged

Fix typo in Include/objimpl.h #5568

merged 1 commit into from Feb 6, 2018

Conversation

WouldYouKindly
Copy link
Contributor

@WouldYouKindly WouldYouKindly commented Feb 6, 2018

No description provided.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Feb 6, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta merged commit 517da1e into python:master Feb 6, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Feb 6, 2018

Thanks @WouldYouKindly for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2018
@WouldYouKindly @miss-islington
Fix typo in Include/objimpl.h, the word "has" was missing (pythonGH-5568
e44accf 
)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 6, 2018

GH-5569 is a backport of this pull request to the 3.7 branch.

@Mariatta
Copy link
Sponsor Member

Mariatta commented Feb 6, 2018

Thanks @WouldYouKindly and congrats on your first contribution to CPython 🌮
For this one word change to the comments, the CLA is not needed. But please sign it for your future contributions.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2018
@WouldYouKindly @miss-islington
Fix typo in Include/objimpl.h, the word "has" was missing (pythonGH-5568
5ed86d2 
)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 6, 2018

GH-5570 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

bedevere-bot commented Feb 6, 2018

GH-5571 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2018
@WouldYouKindly @miss-islington
Fix typo in Include/objimpl.h, the word "has" was missing (pythonGH-5568
5d62304 
)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
@miss-islington @WouldYouKindly
Fix typo in Include/objimpl.h, the word "has" was missing (GH-5568) (G…
972edd9 
…H-5569)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
@miss-islington @WouldYouKindly
Fix typo in Include/objimpl.h, the word "has" was missing (GH-5568) (G…
743b6c0 
…H-5570)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
@miss-islington @WouldYouKindly
Fix typo in Include/objimpl.h, the word "has" was missing (GH-5568) (G…
4029064 
…H-5571)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@WouldYouKindly @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta