Skip to content

[2.7] bpo-29612 : Fix hard link creation in tar extraction when it points to themselves #16958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

j0ack
Copy link

@j0ack j0ack commented Oct 27, 2019

When creating a link from a tarball, if the link target and the file has the same path it raised an exception.

We simply ignore this case at the beginning of the method.

Reopen #5753 since #8700 can not be merged into master

https://bugs.python.org/issue29612

@j0ack j0ack closed this Oct 27, 2019
@j0ack j0ack deleted the bpo-29612 branch October 27, 2019 17:09
@j0ack j0ack reopened this Oct 27, 2019
@zware zware changed the title bpo-29612 : Fix hard link creation in tar extraction when it points to themselves [2.7] bpo-29612 : Fix hard link creation in tar extraction when it points to themselves Dec 18, 2019
@zware
Copy link
Member

zware commented Jan 19, 2020

Hi @j0ack! Unfortunately this did not reach a conclusion before Python 2.7 reached EOL on January 1st. As this does not appear to be a critical security issue, there is almost no chance that it will be accepted in this brief limbo window between end-of-support and the final 2.7.18 release, so I'm going to go ahead and close it.

Thanks for your contribution anyway, and I hope your next one is more fruitful!

@zware zware closed this Jan 19, 2020
@j0ack
Copy link
Author

j0ack commented Jan 20, 2020

Hello,

Thank you for your feedback, I already knew that there were only a tiny chance of making it before EOL. I'll be looking for a new contribution on python 3.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants