New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder entries in Misc/ACKS #17663

Merged

merwok merged 3 commits into master from fix-misc-acks-sort

Dec 20, 2019

+13 −14

Contributor

merwok commented Dec 19, 2019

No description provided.


        reorder entries in Misc/ACKS

b5f87d8

merwok added skip issue skip news labels

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting core review label

merwok reviewed

Misc/ACKS Outdated Show resolved Hide resolved


        revert unwanted

9be838b

merwok reviewed

  
        Dan Lidral-Porter

        Ngalim Siregar

        Tim Gates

        Karthikeyan Singaravelan

merwok Dec 19, 2019

Author Contributor

12 lines added, 13 lines removed because Ngalim Siregar was already in the right spot.


        another reorder

81a3cc5

merwok added needs backport to 3.7 needs backport to 3.8 labels

serhiy-storchaka approved these changes

Member

serhiy-storchaka left a comment

Thank you! I was going to do this myself, it was in my low priority list.

bedevere-bot added awaiting merge and removed awaiting core review labels

merwok merged commit dd1a20f into master

5 checks passed

5 checks passed

Docs

Details

Azure Pipelines PR #20191219.12 succeeded

Details

bedevere/issue-number Issue report skipped

bedevere/news "skip news" label found

continuous-integration/travis-ci/pr The Travis CI build passed

Details

merwok deleted the fix-misc-acks-sort branch

bedevere-bot commented Dec 20, 2019

@merwok: Please replace # with GH- in the commit message next time. Thanks!

miss-islington commented Dec 20, 2019

Thanks @merwok for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

miss-islington commented Dec 20, 2019

Sorry, @merwok, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd1a20f324d88f4171aca480b7972d68cab212c5 3.8

miss-islington assigned merwok

miss-islington commented Dec 20, 2019

Sorry @merwok, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dd1a20f324d88f4171aca480b7972d68cab212c5 3.7

bedevere-bot removed the needs backport to 3.7 label

bedevere-bot commented Dec 20, 2019

GH-17672 is a backport of this pull request to the 3.7 branch.

bedevere-bot removed the needs backport to 3.8 label

bedevere-bot commented Dec 20, 2019

GH-17673 is a backport of this pull request to the 3.8 branch.

Contributor Author

merwok commented Dec 20, 2019

Thanks for review. If the problem comes again, we could add a comment at the end of the file.

Member

serhiy-storchaka commented Dec 20, 2019

Nice idea about a comment at the end of the file!

sthagen added a commit to sthagen/cpython that referenced this pull request


        Merge pull request #111 from python/master

fd7b677

reorder entries in Misc/ACKS (python#17663)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.