Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39087: Add PyUnicode_GetUTF8Buffer(). #17659
Open
+315
−1
Conversation
Lib/test/test_unicode.py
Outdated
from _testcapi import unicode_getutf8buffer, test_unicode_getutf8buffer | ||
|
||
# Run tests wrtten in C. Raise an error when test failed. | ||
test_unicode_getutf8buffer() |
This comment has been minimized.
This comment has been minimized.
vstinner
Dec 20, 2019
Member
Hum. test_capi executes all test_capi attributes with a name starting with "test_". Please check if it's executed. If yes, just rename the method. For example, rename it to unicode_test_getutf8buffer()).
This comment has been minimized.
This comment has been minimized.
methane
Dec 20, 2019
Author
Member
You are right. I confirmed the test_unicode_getutf8buffer is called from test_capi.
I just removed calling test_unicode_getutf8buffer here because there is test_unicode_compare_with_ascii
already.
Let's run the test from test_capi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
methane commentedDec 19, 2019
•
edited by bedevere-bot
Ref: bpo-39087